Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation for mpd playlist commands #2

Closed
ldolse opened this issue Nov 23, 2012 · 4 comments
Closed

documentation for mpd playlist commands #2

ldolse opened this issue Nov 23, 2012 · 4 comments
Labels

Comments

@ldolse
Copy link
Contributor

ldolse commented Nov 23, 2012

The actual playlist commands don't match the playlist commands listed with --help or on the website - e.g. mpd_plst_load should be mpd_load, etc.

Fix for the cli help here:
ldolse/empcd@70eba0f

@massar
Copy link
Owner

massar commented Nov 23, 2012

This was caused by a confusion between the uppercase 'name' and lowercase 'format', some of the name variants where wrong.

Note that "mpd_load" would be ambigues, is it loading a file, a config etc, that is why it is called 'mpd_plst_load' to not make it too long.

Resolved per:
347b306

@massar massar closed this as completed Nov 23, 2012
@ldolse
Copy link
Contributor Author

ldolse commented Nov 23, 2012

The logic makes sense, but the problem with that is it doesn't work:
[ debug] /etc/empcd.conf@0095: key KEY_1 UP mpd_plst_load numkey_one
[ debug] Undefined Function at 9 in 'KEY_1 UP mpd_plst_load numkey_one'

And then empcd exits. That was when I looked at the code and tried mpd_load and discovered that it did work - so I just changed the docs to match what was actually working.

@massar
Copy link
Owner

massar commented Nov 23, 2012

Please do test against the latest version and/or provide at least a snippet of the config file (maybe some weird char got into it? the config file reader is not the smartest of them...)

Also try the full debug with:
./empcd -f -y 10

I've updated the configuration file handling just now so that that error reporting should be better and also a 'nompd' mode for running empcd without a connection to MPD making it a dumb keyboard presser

@massar massar reopened this Nov 23, 2012
@ldolse
Copy link
Contributor Author

ldolse commented Nov 23, 2012

The debug messages were from the commit right after you closed it. I just pulled the latest commits and those have resolved it. Thanks!

@ldolse ldolse closed this as completed Nov 23, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants