Skip to content

Commit

Permalink
Fix RSpec/SharedContext cop (#24847)
Browse files Browse the repository at this point in the history
  • Loading branch information
mjankowski committed May 12, 2023
1 parent 5241f7b commit bf3ebeb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 8 deletions.
5 changes: 0 additions & 5 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -648,11 +648,6 @@ RSpec/RepeatedExampleGroupDescription:
- 'spec/controllers/admin/reports/actions_controller_spec.rb'
- 'spec/policies/report_note_policy_spec.rb'

# This cop supports safe autocorrection (--autocorrect).
RSpec/SharedContext:
Exclude:
- 'spec/services/unsuspend_account_service_spec.rb'

RSpec/StubbedMock:
Exclude:
- 'spec/controllers/api/base_controller_spec.rb'
Expand Down
6 changes: 3 additions & 3 deletions spec/services/unsuspend_account_service_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'rails_helper'

RSpec.describe UnsuspendAccountService, type: :service do
shared_examples 'common behavior' do
shared_context 'with common context' do
subject { described_class.new.call(account) }

let!(:local_follower) { Fabricate(:user, current_sign_in_at: 1.hour.ago).account }
Expand Down Expand Up @@ -36,7 +36,7 @@ def match_update_actor_request(req, account)
expect { subject }.to_not change { account.suspended? }
end

include_examples 'common behavior' do
include_examples 'with common context' do
let!(:account) { Fabricate(:account) }
let!(:remote_follower) { Fabricate(:account, uri: 'https://alice.com', inbox_url: 'https://alice.com/inbox', protocol: :activitypub) }
let!(:remote_reporter) { Fabricate(:account, uri: 'https://bob.com', inbox_url: 'https://bob.com/inbox', protocol: :activitypub) }
Expand All @@ -61,7 +61,7 @@ def match_update_actor_request(req, account)
end

describe 'unsuspending a remote account' do
include_examples 'common behavior' do
include_examples 'with common context' do
let!(:account) { Fabricate(:account, domain: 'bob.com', uri: 'https://bob.com', inbox_url: 'https://bob.com/inbox', protocol: :activitypub) }
let!(:resolve_account_service) { double }

Expand Down

0 comments on commit bf3ebeb

Please sign in to comment.