Save avatar or header correctly even if other one fails (#18465)

* Save avatar or header correctly if other one fails * Fix test
mastodon · Dec 15, 2022 · d412147 · d412147
1 parent 8f8c0fe
commit d412147
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/app/models/account.rb b/app/models/account.rb
@@ -341,9 +341,15 @@ def build_fields
 
   def save_with_optional_media!
     save!
-  rescue ActiveRecord::RecordInvalid
-    self.avatar = nil
-    self.header = nil
+  rescue ActiveRecord::RecordInvalid => e
+    errors = e.record.errors.errors
+    errors.each do |err|
+      if err.attribute == :avatar
+        self.avatar = nil
+      elsif err.attribute == :header
+        self.header = nil
+      end
+    end
 
     save!
   end

diff --git a/spec/models/account_spec.rb b/spec/models/account_spec.rb
@@ -160,7 +160,7 @@
         expect(account.avatar_remote_url).to eq 'https://remote.test/invalid_avatar'
         expect(account.header_remote_url).to eq expectation.header_remote_url
         expect(account.avatar_file_name).to  eq nil
-        expect(account.header_file_name).to  eq nil
+        expect(account.header_file_name).to  eq expectation.header_file_name
       end
     end
   end