Save avatar or header correctly even if other one fails #18465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tribela
force-pushed
the
fix-account-image
branch
2 times, most recently
from
878cd6b
to
1d4a5e7
Compare
tribela
changed the title
tribela
force-pushed
the
fix-account-image
branch
from
1d4a5e7
to
9a1c01f
Compare
ClearlyClaire
approved these changes
May 20, 2022
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Please don't close this, stalebot |
neatchee
pushed a commit
to neatchee/mastodon
that referenced
this pull request
Dec 16, 2022
* Save avatar or header correctly if other one fails * Fix test
nametoolong
pushed a commit
to nametoolong/nuage
that referenced
this pull request
Jan 12, 2023
* Save avatar or header correctly if other one fails * Fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users from remote(misskey or pleroma) may has webp header and png avatar at the same time (or vice versa).
Currently, Mastodon will reject both if one fails, Resulting their profile picture is not shown
This PR fixes that problem.