Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Middle-click-to-scroll expands toot in addition to starting scroll #10798

Closed
creideiki opened this issue May 21, 2019 · 6 comments
Closed

Middle-click-to-scroll expands toot in addition to starting scroll #10798

creideiki opened this issue May 21, 2019 · 6 comments
Labels
bug Something isn't working status/wontfix This will not be worked on

Comments

@creideiki
Copy link

Expected behaviour

I use Firefox autoscroll (middle click then move mouse) almost exclusively, especially on laptops without scroll wheels. This used to work well, with a big open space below the account avatar on each post where middle-clicking was safe.

Actual behaviour

Since v2.8.3, middle-clicking below the avatar expands the toot in addition to starting scrolling.

Steps to reproduce the problem

  1. Enable Preferences -> General -> Browsing -> Use autoscrolling.
  2. Middle-click the open space below the avatar to start scrolling.
  3. Note that the toot is expanded even though it wasn't left-clicked.

Specifications

The web interface of v2.8.3 on mastodon.social, using Firefox 66.0.5 on Gentoo Linux.

Related

It seems the code was added in #10766, to solve #10733.

The same problem has appeared before, in #528, solved in #536.
@Dar13
Copy link
Contributor

Dar13 commented May 24, 2019

I almost thought I couldn't reproduce this issue but I can. If you start dragging the mouse after pressing down the middle button it will not expand the status. If you click the mouse fully before dragging then the status will expand.

I'll take a look at this in the upcoming couple of days (since it was my PR that broke stuff...), hopefully it'll be simple to fix.

@Dar13 Dar13 mentioned this issue May 26, 2019
Merged
Dar13 added a commit to Dar13/mastodon that referenced this issue May 26, 2019
@Dar13
Create new click handler for status__expand area in status
bd8e64f 
This click handler only activates on left-click, resolving mastodon#10798.
This matches behavior in status_content.js, as added in mastodon#536
Gargron pushed a commit that referenced this issue May 26, 2019
@Dar13 @Gargron
Create new click handler for status__expand area in status (#10837)
63483ee 
This click handler only activates on left-click, resolving #10798.
This matches behavior in status_content.js, as added in #536
@Dar13
Copy link
Contributor

Dar13 commented Jun 4, 2019

Seems @Gargron has made mastodon.social run the latest on the master branch, does this issue still occur for you @creideiki?

@creideiki
Copy link
Author

After reloading the web page, I no longer see this issue.

@Dar13
Copy link
Contributor

Dar13 commented Jun 4, 2019

Seems like we can close it then @creideiki @Gargron

@Gargron Gargron added the bug Something isn't working label Aug 5, 2019
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this issue Oct 2, 2019
@Dar13 @hiyuki2578
Create new click handler for status__expand area in status (mastodon#…
9cf674e 
…10837)

This click handler only activates on left-click, resolving mastodon#10798.
This matches behavior in status_content.js, as added in mastodon#536
@stale
Copy link

stale bot commented Oct 26, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status/wontfix This will not be worked on label Oct 26, 2019
@ykzts
Copy link
Sponsor Member

ykzts commented Oct 26, 2019

Resolved with #10837

@ykzts ykzts closed this as completed Oct 26, 2019
rtucker pushed a commit to vulpineclub/mastodon that referenced this issue Jan 7, 2021
@Dar13
Create new click handler for status__expand area in status (mastodon#…
df29ca9 
…10837)

This click handler only activates on left-click, resolving mastodon#10798.
This matches behavior in status_content.js, as added in mastodon#536
messenjahofchrist pushed a commit to Origin-Creative/mastodon that referenced this issue Jul 30, 2021
@Dar13 @Gargron
Create new click handler for status__expand area in status (mastodon#…
9556c65 
…10837)

This click handler only activates on left-click, resolving mastodon#10798.
This matches behavior in status_content.js, as added in mastodon#536
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working status/wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ykzts @Gargron @Dar13 @creideiki