Create new click handler for status__expand area in status #10837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This click handler only activates on left-click, resolving mastodon#10798. This matches behavior in status_content.js, as added in mastodon#536
Gargron
approved these changes
May 26, 2019
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
…10837) This click handler only activates on left-click, resolving mastodon#10798. This matches behavior in status_content.js, as added in mastodon#536
rtucker
pushed a commit
to vulpineclub/mastodon
that referenced
this pull request
Jan 7, 2021
…10837) This click handler only activates on left-click, resolving mastodon#10798. This matches behavior in status_content.js, as added in mastodon#536
messenjahofchrist
pushed a commit
to Origin-Creative/mastodon
that referenced
this pull request
Jul 30, 2021
…10837) This click handler only activates on left-click, resolving mastodon#10798. This matches behavior in status_content.js, as added in mastodon#536
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This click handler only activates on left-click, resolving #10798. This matches behavior in
status_content.js, as added in #536.I can change the default click handler in
status.jsto only perform the history push on left clicks if desired, but held off as that seemed to be a larger UX decision that affects more UI elements than thestatus__expandregion.