Validate nodeinfo response by schema #21395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ineffyble
suggested changes
Nov 24, 2022
MFTabriz
force-pushed
the
validate_nodeinfo_schema
branch
2 times, most recently
from
49d536e
to
f31aae7
Compare
MFTabriz
force-pushed
the
validate_nodeinfo_schema
branch
from
75eb074
to
78fd3e8
Compare
MFTabriz
changed the title
MFTabriz
force-pushed
the
validate_nodeinfo_schema
branch
2 times, most recently
from
e4ac3ac
to
e78d63a
Compare
MFTabriz
force-pushed
the
validate_nodeinfo_schema
branch
3 times, most recently
from
9371244
to
9e8d9ae
Compare
|
Hi @ClearlyClaire ! Can you please check this out or ask someone to review it? |
MFTabriz
force-pushed
the
validate_nodeinfo_schema
branch
from
b87c3b8
to
c4a6ee8
Compare
MFTabriz
force-pushed
the
validate_nodeinfo_schema
branch
from
c4a6ee8
to
328a67e
Compare
MFTabriz
force-pushed
the
validate_nodeinfo_schema
branch
2 times, most recently
from
ee97f56
to
37c5232
Compare
MFTabriz
requested review from
ClearlyClaire
and removed request for
ineffyble
|
This pull request has merge conflicts that must be resolved before it can be merged. |
…node_info_2.0_schema.json
disable throwing errors test the schema matcher
MFTabriz
force-pushed
the
validate_nodeinfo_schema
branch
from
05c7b93
to
617fff2
Compare
ClearlyClaire
requested changes
Dec 10, 2022
MFTabriz
force-pushed
the
validate_nodeinfo_schema
branch
from
617fff2
to
89ee9f6
Compare
Thanks for checking it. I think I fixed all of them. |
ClearlyClaire
approved these changes
Dec 13, 2022
|
@ineffyble you asked for changes when this PR was a draft 3 weeks ago and you did not review it afterwards. I have to ask you again: Can you please check this out? |
ineffyble
approved these changes
Dec 13, 2022
|
@MFTabriz Claire is the one you need sign-off from, I've just been trying to help with PR hygiene :) |
Thank you @ineffyble! With your change request still open, in the list this PR was being shown as “Changes requested”. Now it's marked as "Approved" and the maintainers can easily see that everything has been taken care of. |
neatchee
pushed a commit
to neatchee/mastodon
that referenced
this pull request
Dec 16, 2022
* add json-schema to :test in Gemfile * Create node_info_2.0_schema.json * test match_response_schema * Create match_response_schema.rb * Update nodeinfo_controller_spec.rb * Rename spec/support/node_info_2.0_schema.json to spec/support/schema/node_info_2.0_schema.json * Update match_response_schema.rb * cleanup * additionally validate the json schema itself disable throwing errors test the schema matcher * rename nodeinfo schema to nodeinfo_2.0 * use Rails.root.join to construct the path * prettify json * sync Gemfile.lock
nametoolong
pushed a commit
to nametoolong/nuage
that referenced
this pull request
Jan 12, 2023
* add json-schema to :test in Gemfile * Create node_info_2.0_schema.json * test match_response_schema * Create match_response_schema.rb * Update nodeinfo_controller_spec.rb * Rename spec/support/node_info_2.0_schema.json to spec/support/schema/node_info_2.0_schema.json * Update match_response_schema.rb * cleanup * additionally validate the json schema itself disable throwing errors test the schema matcher * rename nodeinfo schema to nodeinfo_2.0 * use Rails.root.join to construct the path * prettify json * sync Gemfile.lock
darronschall
added a commit
to darronschall/mastodon
that referenced
this pull request
Jan 18, 2023
This aims to be a complete specification and source of truth for how the endpoint behaves. It specifies the responses in both happy and sad paths, error handling, and authentication and authorization handling. Use JSON-schema definitions to validate the API responses via `match_json_schema` added in mastodon#21395. There is some repeated code and abstractions here. The next step is to extract [RSpec shared_examples](https://relishapp.com/rspec/rspec-core/docs/example-groups/shared-examples) to DRY. Another option to consider is moving towards the [`rswag` gem](https://github.com/rswag/rswag) per issue mastodon#20572.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using a new matcher
match_json_schemawhich uses json-schema gem. The schema file is also validated.