Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility of the “Sign out” button on the “/share” page #22547

Closed
2 tasks done
kytta opened this issue Dec 20, 2022 · 3 comments · Fixed by #22549
Closed
2 tasks done

Accessibility of the “Sign out” button on the “/share” page #22547

kytta opened this issue Dec 20, 2022 · 3 comments · Fixed by #22549
Labels
suggestion Feature suggestion

Comments

@kytta
Copy link
Contributor

kytta commented Dec 20, 2022

Pitch

When one user decides to share something on Mastodon via the /share endpoint (for example, by clicking on a “Share” button), the page has a “Sign out” button. Pretty useful, but the meaning of it may also be confusing for some people. It would be nice to improve the button's accessibility by doing the following:

  • add the title attribute to the button, so that on hover, it would say “Sign out”
  • add the aria-* attributes (or alt text) to the button, so that the screen readers would correctly title the button. Right now, it's a link with a text that consists of one unreadable character

Motivation

Foremost, people with sight disabilities would profit from this. I also have received an email from a person that didn't understand the meaning and the reasoning behind even having this button there in the first place.

@kytta kytta added the suggestion Feature suggestion label Dec 20, 2022
kytta added a commit to kytta/mastodon that referenced this issue Dec 20, 2022
@rbairwell
Copy link

Out of interest, which platform are you on? (i.e. Chrome 108 on Windows 10 Pro, Safari 532 on Mac OS 23) etc?

On my Windows 10 Pro machine running Brave 1.46, clicking the "Share" button opens the browser/Windows default share interface (via navigator.share ). I actually can't find the /share endpoint documented or mentioned anywhere - could you provide a full example URL (feel free to mask out the instance name, post id and/or the username).

Just to confirm - your instance is running normal Mastodon v4.0.2 (on the Advanced web view, that's at the bottom of the "Getting started" column - on logged out, it's left hand panel) or is it running something like Mastodon v4.0.2+glitch ?

@kytta
Copy link
Contributor Author

kytta commented Dec 20, 2022

Out of interest, which platform are you on? (i.e. Chrome 108 on Windows 10 Pro, Safari 532 on Mac OS 23) etc?

macOS Monterey 12.6.2, MacBook Pro 14″, 2021, M1 Pro, 16 GB

I actually can't find the /share endpoint documented or mentioned anywhere - could you provide a full example URL

Yes, this is the URL used for “Share” buttons on external pages. For example, you read an article and want to share it with others on Mastodon. The example URL would be https://<INSTANCE_URL>/share?text=Hello%20World.

I develop share buttons and an instance-agnostic share page for Mastodon, which utilize this page.

Just to confirm - your instance is running normal Mastodon v4.0.2

Yep.

@rbairwell
Copy link

Okay, you fixed it faster than I could ;) Still getting used to the Mastodon code base, HAML and Ruby ;) Well done!

Gargron pushed a commit that referenced this issue Jan 5, 2023
nametoolong pushed a commit to nametoolong/nuage that referenced this issue Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion Feature suggestion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants