Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rubocop and rubocop-rspec #26329

Merged
merged 5 commits into from Aug 22, 2023
Merged

Update rubocop and rubocop-rspec #26329

merged 5 commits into from Aug 22, 2023

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Aug 3, 2023

  • Update to the latest versions
  • Autofixed new rules
  • Regenerated TODO files for some other fixed items

@nschonni nschonni marked this pull request as draft August 3, 2023 17:01
@nschonni nschonni force-pushed the rubocop-updates branch 3 times, most recently from 9f0ad86 to 27f0d6f Compare August 3, 2023 18:42
@nschonni nschonni marked this pull request as ready for review August 3, 2023 18:58
@nschonni
Copy link
Contributor Author

nschonni commented Aug 3, 2023

The new RSpec rule might not be fully safe autofix rubocop/rubocop-rspec#1677, but after addressing the first bad autofix, the specs still seem happy

@ClearlyClaire
Copy link
Contributor

I'm not sure we want to update to something that we know have unsafe autofix, but the actual code changes are fine.

@mjankowski
Copy link
Contributor

I'm not sure we want to update to something that we know have unsafe autofix, but the actual code changes are fine.

I have a process question for these style/lint version bump PRs ... is your preference to have either:

  • A PR in this style, where the version bump, the todo regeneration, and all the required changes are all in one big PR (and maybe even one larger commit)
  • More isolated per-change PRs/commits leading up to the version bump/regen (ie for this particular one we'd have a PR for the message chain change, a PR for the argument forwarding; and then only after those are merged, a final PR doing the actual version bump and todo regen if necessary)

My suspicision is that the latter might be easer to review, would love to confirm.

@ClearlyClaire
Copy link
Contributor

I can see both ways having their own advantages:

  • when the changes are purely automatic, having the rule changes before or at the same time as the code changes can help forks which can just discard the automated changes and re-run the autofixer
  • having separate PRs can on the other hand be very slightly easier to review in the main project, and are a bit cleaner in the commit history due to squash-merging

I do not feel very strongly about either solution, tbh.

This was referenced Aug 10, 2023
Closed
Closed
@renchap renchap added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Aug 14, 2023
@renchap
Copy link
Sponsor Member

renchap commented Aug 14, 2023

rubocop-rspec v2.23.2 fixes the issue with RSpec/ReceiveMessages autofix, could you update your PR?

Also there is a new Rubocop version as well.

@nschonni
Copy link
Contributor Author

I think rubocop/rubocop#12111 needs to be released, as I get an error running with the newest rubocop

@renchap
Copy link
Sponsor Member

renchap commented Aug 21, 2023

Looks good, I will let @ClearlyClaire merge!

@ClearlyClaire ClearlyClaire merged commit b970ed6 into mastodon:main Aug 22, 2023
33 checks passed
@nschonni nschonni deleted the rubocop-updates branch August 22, 2023 07:36
jsgoldstein added a commit to jsgoldstein/mastodon that referenced this pull request Aug 28, 2023
@jsgoldstein @renovate
@ThisIsMissEm @ClearlyClaire @renchap @c960657 @gunchleoc @JAYKALIA007 @mjankowski @Plastikmensch @Gargron @progval @danielmbrasil @CSDUMMI @github-actions @web-flow @e-nomem @Foritus @nschonni @tribela @mgmn @HonkingGoose @arbolitoloco1 @Jorijn @NicolaiSoeborg @rrgeorge @yufushiro @AntoninDelFabbro @sinoru
Add basic es tests (#12)
02c4a11 
* Update dependency haml_lint to v0.49.2 (mastodon#26222)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Fix: Streaming server memory leak in HTTP EventSource cleanup (mastodon#26228)

* Swap debug statements in streaming server (mastodon#26231)

* Fix missing return values in streaming (mastodon#26233)

* Use original URL in preview if it redirects to 4xx page (mastodon#26200)

* Allow filtering for Chinese languages (mastodon#26066)

* Update README.md (mastodon#25435)

* Add end-to-end (system) tests (mastodon#25461)

* Rubocop fix: `Perfomance/UnfreezeString` (mastodon#26217)

* Update rubocop rules for linelength (mastodon#26190)

* Add coverage for `LanguageValidator` (mastodon#25593)

* Add coverage for `URLValidator` (mastodon#25591)

* Fix `RSpec/EmptyExampleGroup` cop (mastodon#24735)

* Profiling tools configuration improvement (mastodon#25383)

* Load `rspec-rails` gem in `test` + `development` (mastodon#25768)

* Ignore the brakeman `PermitAttributes` check (mastodon#25915)

* Fix public TL not indicating new toots when `onlyRemote` is enabled (mastodon#26247)

Signed-off-by: Plastikmensch <plastikmensch@users.noreply.github.com>

* Remove obsolete backport from Rails 7 (mastodon#26254)

* Change aspect ratios on link previews in web UI (mastodon#26250)

* Fix `Importer::BaseImporter#clean_up!` not using proper primary key (mastodon#26269)

* Bump version to v4.1.6 (mastodon#26272)

* Do not normalize URL before fetching it (mastodon#26219)

* Change /api/v1/peers/search to be case-insensitive when using Elasticsearch (mastodon#26268)

* Change interaction modal input to disable browser spell-checking, capitalization and autocomplete (mastodon#26267)

* Fix AVIF attachments (mastodon#26264)

* Add List-Unsubscribe email header (mastodon#26085)

* Fix wrong border radius on link cards in web UI (mastodon#26287)

* Fix line clamp for link previews in web UI (mastodon#26286)

* Change design of role badges in web UI (mastodon#26281)

Co-authored-by: Claire <claire.github-309c@sitedethib.com>

* Fix request URL normalisation for bare domain and 8-bit characters (mastodon#26285)

* Refactor: replace whitelist_mode mentions with limited_federation_mode (mastodon#26252)

* change column link to add a better keyboard focus indicator (mastodon#26278)

* Fix crash in `tootctl status remove` and some old migrations (mastodon#26210)

* Add client-side timeout on resend confirmation button (mastodon#26300)

* Allow spaces around commas in ALLOWED_PRIVATE_ADDRESSES (mastodon#26297)

* Change indexing frequency from 5 minutes to 1 minute, add locks to schedulers (mastodon#26304)

* Add primary key to preview_cards_statuses join table (includes deduplication migration) (mastodon#25243)

* Add `GET /api/v1/instance/languages` to REST API (mastodon#24443)

Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>
Co-authored-by: Claire <claire.github-309c@sitedethib.com>

* Update dependency aws-sdk-s3 to v1.132.0 (mastodon#26227)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Add alt text for preview card thumbnails (mastodon#26184)

* Update dependency rack to v2.2.8 (mastodon#26312)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency react-redux to v8.1.2 (mastodon#26314)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency test-prof to v1.2.2 (mastodon#26316)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency core-js to v3.32.0 (mastodon#26317)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency lograge to v0.13.0 (mastodon#26318)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Rename “read” database to “replica” for consistency (mastodon#26326)

* Update dependency selenium-webdriver to v4.10.0 (mastodon#26322)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency rack-attack to v6.7.0 (mastodon#26319)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Add direct link to the Single-Sign On provider if there is only one sign up method available (mastodon#26083)

* Re-add StatsD support through the `nsa` gem (mastodon#26310)

* Change reblogs to be excluded from "Posts and replies" tab in web UI (mastodon#26302)

* Change design of hidden media overlay (again) in web UI (mastodon#26330)

* Fix incorrect model annotation for List#exclusive (mastodon#26313)

* Fix light theme select option for hashtags (mastodon#26311)

* Fix confirmation when closing media edition modal with unsaved changes (mastodon#26342)

* Change streaming `/metrics` to include additional metrics (mastodon#26299)

* Fix missing cached preview cards attributes (mastodon#26343)

* Fix report modal secondary buttons style (mastodon#26341)

* Change header of hashtag timelines in web UI (mastodon#26362)

* New Crowdin Translations (automated) (mastodon#26209)

Co-authored-by: GitHub Actions <noreply@github.com>
Co-authored-by: Claire <claire.github-309c@sitedethib.com>

* Make mastodon-streaming systemd unit templated (mastodon#24751)

Co-authored-by: Emelia Smith <ThisIsMissEm@users.noreply.github.com>

* Spec media attachment speedups (mastodon#25416)

* Fix interaction modal layout (mastodon#26368)

* Fix list import concurrently creating lists of the same name (mastodon#26372)

* Omniauth 2.0 version bump (mastodon#24209)

* Change account search tokenizer and queries (mastodon#26378)

* Fix adding column with default value taking longer on Postgres >= 11 (mastodon#26375)

* Fix `preview_cards_statuses_pkey` not being reindexed concurrently (mastodon#26384)

* Change `DB_REPLICA_*` environment variables to `REPLICA_DB_*` (mastodon#26386)

* Fix Content Security Policy sometimes unnecessarily allowing hCaptcha scripts (mastodon#26388)

* Prepare v4.2.0-beta1 (mastodon#26339)

* Fix blocking subdomains of an already-blocked domain (mastodon#26392)

* Use migration classes in migrations where current definition conflicts with older (mastodon#26390)

* Restore console behavior in `test` env (mastodon#26401)

* Change: Block GPTBot (mastodon#26396)

* Avoid connecting to a running ES instance in ES search check spec (mastodon#26413)

* Change the hashtag column to not display the hashtag header on pinned columns (mastodon#26416)

* Update dependency sass to v1.64.2 (mastodon#26315)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update eslint (non-major) (mastodon#26323)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* New Crowdin Translations (automated) (mastodon#26373)

Co-authored-by: GitHub Actions <noreply@github.com>
Co-authored-by: Claire <claire.github-309c@sitedethib.com>

* Update dependency aws-sdk-s3 to v1.132.1 (mastodon#26423)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency immutable to v4.3.2 (mastodon#26425)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency haml_lint to v0.49.3 (mastodon#26424)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency eslint-config-prettier to v9 (mastodon#26434)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency sass to v1.65.1 (mastodon#26433)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency mime-types to '~> 3.5.0' (mastodon#26431)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency regenerator-runtime to ^0.14.0 (mastodon#26432)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency rails to v7.0.7 (mastodon#26428)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency @rails/ujs to v7.0.7 (mastodon#26422)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency pg to v8.11.2 (mastodon#26426)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update babel monorepo to v7.22.10 (mastodon#26421)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency eslint-import-resolver-typescript to v3.6.0 (mastodon#26429)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency pg-connection-string to v2.6.2 (mastodon#26427)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Add `S3_DISABLE_CHECKSUM_MODE` environment variable for compatibility with some S3-compatible providers (mastodon#26435)

* Merge duplicate Gemfile groups (mastodon#26441)

* Upgrade JS dev dependencies (mastodon#26442)

* Fix reply not preserving the language from the replied-to post (mastodon#26452)

* Add missing instances option to tootctl search deploy (mastodon#26461)

* Remove old non-unique index on preview_cards statuses join table (mastodon#26447)

* Upgrade `@types/react` (mastodon#26457)

* Fix "Create Account" button in interaction modal (mastodon#26459)

* Improve Renovate configuration (mastodon#26306)

* Update dependency faker to v3.2.1 (mastodon#26474)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency autoprefixer to v10.4.15 (mastodon#26473)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency nokogiri to v1.15.4 (mastodon#26476)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Fix `lint:json` not processing `json5` extension (mastodon#26481)

* New Crowdin Translations (automated) (mastodon#26444)

Co-authored-by: GitHub Actions <noreply@github.com>
Co-authored-by: Claire <claire.github-309c@sitedethib.com>

* Add `ES_PRESET` option to customize numbers of shards and replicas (mastodon#26483)

Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>

* Fix `repo:changelog` task matching strings that are not Pull Request identifiers (mastodon#26280)

* Add privacy tab in profile settings (mastodon#26484)

Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>

* Add support for `indexable` attribute on remote actors (mastodon#26485)

Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>

* Fix ES_PRESET not being applied to Chewy's internal index (mastodon#26489)

* Fix unfollow icon styling in advanced column (mastodon#26482)

* Add display of out-of-band hashtags in the web interface (mastodon#26492)

Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>

* Fix hashtag bar display when status is in a thread (mastodon#26497)

* Update dependency postcss to v8.4.28 (mastodon#26502)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Fix hashtag bar sometimes including tags that appear in the post's body (mastodon#26506)

* Fix “legal” report category not showing up in moderation interface (mastodon#26509)

* Change “privacy and reach” settings so that unchecking boxes always increase privacy and checking them always increase reach (mastodon#26508)

* Fix case-insensitive comparison of hashtags to do case-folding (mastodon#26525)

* Fix cached posts including stale stats (mastodon#26409)

* Update dependency pg to v8.11.3 (mastodon#26519)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Allow setting a custom HTTP method in CacheBuster (mastodon#26528)

Co-authored-by: Jorijn Schrijvershof <jorijn@jorijn.com>

* Fix `frame_rate` for videos where `ffprobe` reports 0/0 (mastodon#26500)

* Update dependency puma to v6.3.1 (mastodon#26537)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency @material-design-icons/svg to v0.14.11 (mastodon#26536)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Remove redundant ready() wrapper (mastodon#26533)

* Fix: support both DATABASE_URL and DB_PASS (mastodon#26295)

* Fix already initialized constant warning (mastodon#26542)

* Change follow recommendation materialized view to be faster in most cases (mastodon#26545)

Co-authored-by: Renaud Chaput <renchap@gmail.com>

* Fix profile picture preview (mastodon#26538)

* Add ability to delete avatar or header picture via the API (mastodon#25124)

Co-authored-by: Claire <claire.github-309c@sitedethib.com>

* Do not start LibreTranslate and Elasticsearch on GitHub Codespaces (mastodon#26382)

* Update dependency core-js to v3.32.1 (mastodon#26548)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update eslint (non-major) (mastodon#26567)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Refactor `Api::V1::ProfilesController` into two separate controllers (mastodon#26573)

* Add auto-refresh of accounts we get new messages/edits of (mastodon#26510)

* Add Elasticsearch cluster health check and indexes mismatch check to dashboard (mastodon#26448)

* Remove hashtags from the last line of a status if it only contains hashtags (mastodon#26499)

* Bump version to v4.2.0-beta2 (mastodon#26579)

* Fix layout of the closed registrations modal (mastodon#26593)

* Update rubocop and rubocop-rspec (mastodon#26329)

* Add `circular-dependency-plugin` to detect any circular deps issues (mastodon#26600)

* Update `SECURITY.md` to indicate issues can be reported on Github (mastodon#26599)

* Update dependency mime-types to v3.5.1 (mastodon#26595)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Add cherokee to languages dropdown (mastodon#26012)

* Add Kalmyk to languages dropdown (mastodon#26013)

* Fix admin dashboard check when using Elasticsearch with `ES_PREFIX` (mastodon#26605)

* Better hashtag normalization when processing a post (mastodon#26614)

* Update dependency rails to v7.0.7.2 (mastodon#26612)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency react-textarea-autosize to v8.5.3 (mastodon#26607)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Add support for federating `memorial` attribute  (mastodon#26583)

* Fix unexpected audio stream transcoding when uploaded video is eligible to passthrough (mastodon#26608)

Co-authored-by: Claire <claire.github-309c@sitedethib.com>

* Update Account Search to prioritize username over display name (mastodon#26623)

* Change the hashtag bar to be hidden when there is a CW and the post is not expanded (mastodon#26615)

* Fix some React warnings (mastodon#26609)

* Change hashtag bar tags to be de-emphasized (mastodon#26606)

* Update dependency immutable to v4.3.3 (mastodon#26622)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency oj to v3.16.0 (mastodon#26520)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency sass to v1.66.1 (mastodon#26534)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Add elastic search installation into Vagrantfile (mastodon#26512)

* Fix timeout on invalid set of exclusionary parameters in `/api/v1/timelines/public` (mastodon#26239)

* Change opacity of the delete icon in the search field to be more visible (mastodon#26449)

* Update dependency rspec-sidekiq to v4 (mastodon#26627)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Consolidate inclusion of `admin` js pack link (mastodon#26628)

* Update dependency redis to v4.6.8 (mastodon#26630)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Fix: Workaround to load MASTODON_VERSION_* in Docker. (mastodon#26591)

Co-authored-by: Claire <claire.github-309c@sitedethib.com>

* Fix selecting domains to forward reports to not passing the information correctly (mastodon#26636)

* Fix clicking “Explore” or “Live feeds” column headers to scroll in advanced mode (mastodon#26633)

Co-authored-by: Plastikmensch <Plastikmensch@users.noreply.github.com>

* Change admin e-mail notification settins to be their own settings group (mastodon#26596)

* Change nightlies versioning from `v4.2.0+2023-08-23` to `v4.2.0-nightly.2023-08-23` (mastodon#26626)

* Add new public status index (mastodon#26344)

Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>
Co-authored-by: Claire <claire.github-309c@sitedethib.com>

* Fix changelog wording and missing items (mastodon#26638)

* Update babel monorepo to v7.22.11 (mastodon#26640)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Add `data-nosnippet` attribute to remote posts and local posts with `noindex` (mastodon#26648)

* Add PublicStatusesCheck to Elasticsearch index check on admin dashboard (mastodon#26650)

* Add Elasticsearch/OpenSearch version to “Software” in admin dashboard (mastodon#26652)

* Fix statuses search Elasticsearch query (mastodon#26657)

* Update dependency immutable to v4.3.4 (mastodon#26655)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update ordering to use `id` from body of document instead of deprecated `_id` (mastodon#26659)

* Fix dashboard check for Elasticsearch suggested command including incorrect names (mastodon#26658)

* Change the pre-release versioning scheme and associated environment variables (mastodon#26653)

* Fix toast saying "published" instead of "saved" after editing post in web UI (mastodon#26664)

* Fix nightly build version (mastodon#26676)

* Change queue of job when opting into search from `default` to `pull` (mastodon#26688)

* Fix unnecessary condition causing seqscan when indexing (mastodon#26689)

* Change indexing jobs to use database replica (mastodon#26692)

* Update eslint (non-major) (mastodon#26694)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Fix not being able to negate prefix clauses in search (mastodon#26672)

* Update dependency haml_lint to v0.50.0 (mastodon#26665)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update DefinitelyTyped types (non-major) (mastodon#26693)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Fix multiple issues with status index mappings (mastodon#26686)

* Update dependency @testing-library/jest-dom to v6 (mastodon#26479)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Renaud Chaput <renchap@gmail.com>

* Add `from:me` syntax to search (mastodon#26660)

* Add search options to search popout in web UI (mastodon#26662)

* Fix incorrect call to `PublicStatusesIndex.import` (mastodon#26697)

* A first pass at adding some basic ES tests

* Add more tests

---------

Signed-off-by: Plastikmensch <plastikmensch@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Emelia Smith <ThisIsMissEm@users.noreply.github.com>
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Co-authored-by: Renaud Chaput <renchap@gmail.com>
Co-authored-by: Christian Schmidt <github@chsc.dk>
Co-authored-by: gunchleoc <fios@foramnagaidhlig.net>
Co-authored-by: Jay Prakash Kalia <jaykalia047@gmail.com>
Co-authored-by: Matt Jankowski <matt@jankowski.online>
Co-authored-by: Plastikmensch <Plastikmensch@users.noreply.github.com>
Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>
Co-authored-by: Trevor Wolf <teeerevor@gmail.com>
Co-authored-by: Val Lorentz <progval+github@progval.net>
Co-authored-by: Daniel M Brasil <danielmbrasil@protonmail.com>
Co-authored-by: CSDUMMI <31551856+CSDUMMI@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: GitHub Actions <noreply@github.com>
Co-authored-by: Eashwar Ranganathan <eranganathan@lyft.com>
Co-authored-by: Foritus <rich@aornis.com>
Co-authored-by: Nick Schonning <nschonni@gmail.com>
Co-authored-by: Jeong Arm <kjwonmail@gmail.com>
Co-authored-by: mogaminsk <mgmnjp@icloud.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: Santiago Kozak <santikzk1406@gmail.com>
Co-authored-by: Jorijn Schrijvershof <jorijn@jorijn.com>
Co-authored-by: Nicolai Søborg <NicolaiSoeborg@users.noreply.github.com>
Co-authored-by: Robert R George <rgeorge@midnightweb.net>
Co-authored-by: yufushiro <62991447+yufushiro@users.noreply.github.com>
Co-authored-by: Antonin Del Fabbro <30950182+AntoninDelFabbro@users.noreply.github.com>
Co-authored-by: Jaehong Kang <sinoru@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renchap renchap renchap approved these changes

@ClearlyClaire ClearlyClaire ClearlyClaire approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nschonni @ClearlyClaire @mjankowski @renchap