Add include_pagination_headers matcher to check Link header in api specs
#29596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjankowski
added
testing
ClearlyClaire
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the spec changes and matcher addition from #28826
I think this is a slight improvement/streamlining of these specs even if we don't pull in that concern change from the PR -- and it may make that one easier to review if this is in first.
The matcher here is in theory flexible enough to use on other Link headers if we have them, but for now I'm just using it in the api specs to check for the next/prev url values.
In a few spots, this let us combine what were previously multi-request examples into single ones, so there may be a marginal speedup here too.