Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local bios get corrupted when resolving a profile or status URI #4067

Closed
nightpool opened this issue Jul 4, 2017 · 1 comment
Closed

local bios get corrupted when resolving a profile or status URI #4067

nightpool opened this issue Jul 4, 2017 · 1 comment
Labels
bug Something isn't working

Comments

@nightpool
Copy link
Member

nightpool commented Jul 4, 2017

If you use the "search" feature to resolve a local URI (such as https://cybre.space/@nightpool/58041) it automatically fetches the bio from retrieved atom representation and updates the local user model accordingly.

however, the bios returned via atom are HTML-formatted, while local users do not have html formatted bios, only plain-text formatted ones. This ambiguity in storage formats leads to the bios being corrupted with escaped versions of the html formatting. In extreme cases, they can get corrupted multiple times, as seen below:

image

(s/o to @0x1f415@mastodon.social for the screenshot)

the correct resolution here is one or both of:

  • don't resolve local URI searches using a http request—just return the correct information automatically

  • store both local and remote bios in the database as the same format, to avoid the whole class of bugs where we forget to treat local and remote bios differently

@nightpool nightpool added bug Something isn't working priority - medium labels Jul 4, 2017
@nightpool
Copy link
Member Author

nightpool commented Jul 11, 2017

@Gargron were you going to take this and work on it? I got that impression from the convo we had, but if no-one is working on this I might be able to poke at it a little

masarakki pushed a commit to masarakki/mastodon that referenced this issue Jul 13, 2017
masarakki added a commit to dwango/mastodon that referenced this issue Jul 13, 2017
Fix mastodon#4067 - Do not make HTTP round-trip when resolving local URL (mastodon#4160)
abcang pushed a commit to pixiv/mastodon that referenced this issue Jul 24, 2017
abcang added a commit to pixiv/mastodon that referenced this issue Jul 24, 2017
Fix mastodon#4067 - Do not make HTTP round-trip when resolving local URL (mastodon#4160)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant