Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Salmon and PubSubHubbub #11205

Merged
merged 3 commits into from
Jul 6, 2019
Merged

Remove Salmon and PubSubHubbub #11205

merged 3 commits into from
Jul 6, 2019

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Jun 28, 2019

This prevents the reception of messages through OStatus as well as renewal of OStatus subscriptions in both directions. The admin page for PubSubHubbub subscriptions has been removed as it would no longer serve any purpose.

Removing support for OStatus has been a goal since Mastodon's switch to ActivityPub in 2017. Maintaining two separate code paths for sending and receiving messages increases vectors for attacks and some parts of the OStatus draft protocol are inherently less secure than ActivityPub. At this point the fediverse is almost entirely based on ActivityPub, with GNU Social remaining the only OStatus-only platform.

FIx #10740

  • Salmon endpoint removed
  • PuSH endpoints removed
  • Processing statuses from Atom removed
  • Processing accounts from Atom removed
  • Distributing updates over PuSH removed
  • Deprecated REST API POST /api/v1/follows removed
  • Sending Salmon slaps removed

@Gargron Gargron added the activitypub Protocol-related changes, federation label Jun 28, 2019
@Gargron Gargron force-pushed the feature-remove-ostatus branch 2 times, most recently from f5e9049 to 7618118 Compare June 29, 2019 00:53
@Gargron Gargron added the work in progress Not to be merged, currently being worked on label Jun 29, 2019
@Gargron Gargron force-pushed the feature-remove-ostatus branch 4 times, most recently from 6557b3d to 11f794a Compare June 29, 2019 21:15
@Gargron Gargron added api REST API, Streaming API, Web Push API breaking Incompatible with previous versions and removed work in progress Not to be merged, currently being worked on labels Jun 29, 2019
@Gargron Gargron changed the title Remove Salmon and PubSubHubbub endpoints Remove Salmon and PubSubHubbub Jun 29, 2019
@Gargron Gargron merged commit 23aeef5 into master Jul 6, 2019
@Gargron Gargron deleted the feature-remove-ostatus branch July 6, 2019 21:26
@kevinmarks
Copy link

Removing WebSub is a shame. That means anyone subscribing to a mastodon account in a feed reader is going to have to poll more.

hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
* Remove Salmon and PubSubHubbub endpoints

* Add error when trying to follow OStatus accounts

* Fix new accounts not being created in ResolveAccountService
messenjahofchrist pushed a commit to Origin-Creative/mastodon that referenced this pull request Jul 30, 2021
* Remove Salmon and PubSubHubbub endpoints

* Add error when trying to follow OStatus accounts

* Fix new accounts not being created in ResolveAccountService
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
activitypub Protocol-related changes, federation api REST API, Streaming API, Web Push API breaking Incompatible with previous versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove OStatus-related code
3 participants