Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version bumps for ruby and misc gems #1159

Merged
merged 50 commits into from Apr 10, 2017
Merged

Version bumps for ruby and misc gems #1159

merged 50 commits into from Apr 10, 2017

Conversation

mjankowski
Copy link
Contributor

Brings ruby to version 2.4.1 and misc gems to their latest stable releases.

@mjankowski mjankowski closed this Apr 7, 2017
@mjankowski mjankowski deleted the mj-versions branch April 7, 2017 20:09
@mjankowski mjankowski restored the mj-versions branch April 7, 2017 20:52
@mjankowski mjankowski reopened this Apr 7, 2017
@Gargron
Copy link
Member

Gargron commented Apr 8, 2017

This will require a lot of people to reinstall ruby/recompile their docker images completely. I suggest waiting on this for at least a week or two more as I do not want to stretch admins' nerves too much.

@Gargron Gargron added the deployment Related to runtime configuration, production setups label Apr 8, 2017
@mjankowski
Copy link
Contributor Author

No problem, I'll keep it around.

Is the issue for admins there the ruby version bump, or just any bundler bumps at all? (I'm deploying to Heroku w/out Docker, not totally sure on what the Docker issues are).

If ruby alone is the issue, I can pull that one commit out of here and just get the gem updates in, and save ruby for later.

@mjankowski mjankowski force-pushed the mj-versions branch 4 times, most recently from 23b66fc to 8414b7b Compare April 9, 2017 18:44
@mjankowski mjankowski mentioned this pull request Apr 9, 2017
Closed
@Gargron
Copy link
Member

Gargron commented Apr 9, 2017

Bundler bumps are OK! They don't break anything.

Correct me if I'm wrong, but changing .ruby-version will make Bundler complain about wrong Ruby version, right?

If I'm wrong about that then I retract my line of reasoning and the upgrade would probably be non-breaking.

@mjankowski
Copy link
Contributor Author

With the ruby version bump, here's stuff I can think of which would happen:

  • People doing development will be mildly irritated, because they'll have to do an rbenv install 2.4.1 (or whatever they use) and then cd in and out of the project dir, and then bundle install again ... this should be a familiar thing for most rails devs, won't take too long.
  • People who are doing very very manual server admin work will need to do a manual ruby version upgrade prior to their next deploy, to have the right version in place. I suspect there are very few people just using system rubies instead of rbenv/rvm/etc (or something like heroku or docker)
  • People using heroku will "automatically" upgrade on next deploy, because heroku detects the version change in Gemfile and updates ruby for you
  • I think that for people using Docker, that the "onbuild" instruction here which was already in place will tell Docker to put ruby in place, and will just use the newer ruby version the next time it builds. I am not a Docker expert though, and am not 100% sure that this is always the behavior, or how that works precisely.

@mjankowski mjankowski force-pushed the mj-versions branch 4 times, most recently from a8f596a to 5a8d681 Compare April 10, 2017 19:20
@mjankowski
Update doorkeeper to version 4.2.5
dbad824
@mjankowski
Update faker to version 1.7.3
29297ea
@mjankowski
Update aws-sdk to version 2.9.5
f60c1a3
@mjankowski
Update fabrication to version 2.16.1
80c760f
@mjankowski
Update hamlit-rails to version 0.2.0
ed134f1
@mjankowski
Update http to version 2.2.1
b583798
@mjankowski
Update httplog to version 0.99.2
80bff13
@mjankowski
Update sidekiq to version 4.2.10
4ceb20c
@mjankowski
Update rspec-sidekiq to version 3.0.0
e1af9cc
@mjankowski
Update pghero to version 1.6.4
47cd345
@mjankowski
Update rack-cors to version 0.4.1
d4da8f2
@mjankowski
Update i18n-tasks to version 0.9.13
f9129ce
@mjankowski
Update ruby-oembed to version 0.12.0
1266d17
@mjankowski
Update jquery-rails to version 4.3.1
1e041ce
@mjankowski
Update simple_form to version 3.4.0
d211928
@mjankowski
Update react-rails to version 1.11.0
ea444d2
@mjankowski
Update aws-sdk to version 2.9.6
0b2faa4
@mjankowski
Update sidekiq-unique-jobs to version 5.0.0
7f1e416
@mjankowski
Update uglifier to version 3.2.0
f423cbc
@Gargron Gargron merged commit 64dbde0 into mastodon:master Apr 10, 2017
@mjankowski
Copy link
Contributor Author

Awesome, thanks. I'll attempt to stand by if anyone has weird upgrade issues...

@mjankowski mjankowski deleted the mj-versions branch April 10, 2017 21:07
@Fastidious
Copy link

Can the old image 2.3.1-alpine be removed after this has installed 2.4.1-alpine?

@Wonderfall
Copy link
Contributor

@Fastidious docker rmi ruby:2.3.1-alpine
docker system prune -a -f to remove all unused images.

@akihikodaki akihikodaki mentioned this pull request Apr 16, 2017
Closed
1 task
Nyoho referenced this pull request in Nyoho/mathtodon Apr 25, 2017
@mjankowski @Gargron
Version bumps for ruby and misc gems (#1159)
d1cb16a 
* Update rspec-rails to version 3.5.2

* Update addressable to version 2.5.1

* Update autoprefixer-rails to version 6.7.7.1

* Update bullet to version 5.5.1

* Update domain_name to version 0.5.20170404

* Update letter_opener_web to version 1.3.1

* Upate redis-rails to version 5.0.2

* Update active_record_query_trace to version 1.5.4

* Update capistrano-rails to version 1.2.3

* Update dotenv-rails to version 2.2.0

* Update pg to version 0.20.0

* Update tilt to version 2.0.7

* Update warden to version 1.2.7

* Update tins to version 1.13.2

* Update terminal-table to version 1.7.3

* Update oj to version 2.18.5

* Update simplecov to version 0.14.1

* Update uglifier to version 3.1.13

* Update hashdiff to version 0.3.2

* Update webmock to version 2.3.2

* Update devise to version 4.2.1

* Use ruby version 2.4.1

* Update sass to version 3.4.23

* Update puma to version 3.8.2

* Update will_paginate to version 3.1.5

* Update font-awesome-rails to version 4.7.0.1

* Update fuubar to version 2.2.0

* Update pry-rails to version 0.3.6

* Update simple-navigation to version 4.0.5

* Update rubocop to version 0.48.1

* Update doorkeeper to version 4.2.5

* Update faker to version 1.7.3

* Update aws-sdk to version 2.9.5

* Update fabrication to version 2.16.1

* Update hamlit-rails to version 0.2.0

* Update http to version 2.2.1

* Update httplog to version 0.99.2

* Update sidekiq to version 4.2.10

* Update rspec-sidekiq to version 3.0.0

* Update pghero to version 1.6.4

* Update rack-cors to version 0.4.1

* Update i18n-tasks to version 0.9.13

* Update ruby-oembed to version 0.12.0

* Update jquery-rails to version 4.3.1

* Update simple_form to version 3.4.0

* Update react-rails to version 1.11.0

* Update aws-sdk to version 2.9.6

* Update sidekiq-unique-jobs to version 5.0.0

* Update uglifier to version 3.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gargron Gargron Gargron approved these changes

Assignees
No one assigned
Labels
deployment Related to runtime configuration, production setups
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mjankowski @Gargron @Fastidious @Wonderfall