Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error description and button to copy stack trace to web UI #12033

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Oct 1, 2019

image

@Gargron Gargron added the ui Front-end, design label Oct 1, 2019
@ClearlyClaire
Copy link
Contributor

glitch-soc has something like that for stack trace, but it isn't terribly useful as the stack trace is on the minified code and isn't mapped to the source-map

@shleeable
Copy link
Contributor

Another PR, another killed mascot.

@witcheslive
Copy link

Now we all know how the Mastodon went extinct 😭

@Gargron Gargron force-pushed the feature-copy-stacktrace-web branch from 40773b2 to a38c7e3 Compare October 1, 2019 17:11
@Gargron Gargron closed this Oct 1, 2019
@Gargron Gargron deleted the feature-copy-stacktrace-web branch October 1, 2019 17:37
@Gargron Gargron restored the feature-copy-stacktrace-web branch October 1, 2019 18:32
@Gargron Gargron reopened this Oct 1, 2019
@Gargron Gargron force-pushed the feature-copy-stacktrace-web branch from a38c7e3 to a033f0d Compare October 1, 2019 18:32
@Gargron
Copy link
Member Author

Gargron commented Oct 1, 2019

The elephant graphic is shaped irregularly which makes it very hard to position next to text in a way that looks clean, and its color scheme is not meant to be next to red error text, as the graphic was originally designed for in-column errors accompanied by greyed out, short phrases.

I think ultimately it's more important to say in clear words that the page crashed and what can be done about it than to show a cartoon elephant.

@Gargron Gargron merged commit cbaea09 into master Oct 1, 2019
@Gargron Gargron deleted the feature-copy-stacktrace-web branch October 1, 2019 18:48
@witcheslive
Copy link

Just giving you a hard time mostly, I absolutely do agree that the current behavior is not ideal and somewhat confusing, though it would be nice to have a mascot on there as it is somewhat calming and also fairly common. Even on this fine web sight there's the git cat making joke about the star track: https://github.com/l;asjdf;'asjf

I don't know what the possibility or budget is for perhaps doing a new mascot that fits an error page better, but it should be considered probably.

@koyuawsmbrtn
Copy link
Contributor

I think this looks very clean and professional. This way normies really know that the site crashed and not that their computer might went bonkers.

hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Front-end, design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants