Fix old migration failing with new status default scope #12493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
approved these changes
Dec 4, 2019
|
Got the same error, and cherry-picked this PR, looks like it dose not work. |
|
Sorry, forgot run docker build first, trying. |
|
@Gargron Hi can we add some special notice for people who is upgrading from older version to v3.0.1 to prevented this issue? |
|
What error do you get after applying this patch? |
|
Sorry not familiar with rails, but maybe rails thinks the changes you made in this PR is already migrated and trying to run the next migration with error? @ThibG |
|
@ThibG Sorry I think I should run the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.