Fix rendering <a> without href when scheme unsupported
#13040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
requested changes
Feb 4, 2020
|
I'm not opposed to removing the Also, a |
Gargron
force-pushed
the
fix-hrefless-anchors
branch
from
c49dbd2
to
d0ba3fa
Compare
ClearlyClaire
approved these changes
Feb 7, 2020
| end | ||
| rescue Addressable::URI::InvalidURIError | ||
| nil | ||
| end |
There was a problem hiding this comment.
This whole thing is done without fully parsing URLs in Sanitize
cf. https://github.com/rgrove/sanitize/blob/master/lib/sanitize/transformers/clean_element.rb#L143
It's probably safer (in terms of possible changed behaviors) and more CPU-efficient to do it the same way.
Btw, I think we should either reject URLs or rewrite them to be relative to the original status (an option I prefer, but is maybe not worth it).
Gargron
force-pushed
the
fix-hrefless-anchors
branch
2 times, most recently
from
8160ace
to
543551e
Compare
- Disallow links with relative paths - Disallow iframes with non-http protocols and relative paths Close #13037
Gargron
force-pushed
the
fix-hrefless-anchors
branch
from
543551e
to
1b5ca22
Compare
ClearlyClaire
approved these changes
Feb 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #13037
This replaces an
<a>that has nohrefwith its children. But maybe we don't want any children elements like<span>to stick around?