Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve scrolling behaviour #1415

Merged
merged 2 commits into from Apr 10, 2017
Merged

Improve scrolling behaviour #1415

merged 2 commits into from Apr 10, 2017

Conversation

ticky
Copy link
Contributor

@ticky ticky commented Apr 10, 2017

  • This switches from using margin to using padding.
    • This means column backgrounds need to be painted inside the scrollable area rather than on the background of the column.
    • As a side-effect, it seems to provide a very minor boost to drawing performance, at the cost of a small amount of obviousness!
    • The padding also means the UI can scroll right to the end horizontally.
  • This also fixes an issue where small browsers would encounter ~10px of horizontal scrolling.
  • A few duplicate/overloaded CSS specifications were removed.
    • The ones that the browser used are the ones which stayed!
  • The empty column indicator’s contents were set to flex to the centre so it can have a background applied, and could be squashed correctly by the column settings.
  • Fixes Right-hand margin missing #1412

Screenshots:
320px wide:
screen shot 2017-04-10 at 8 45 39 pm

340px wide:
screen shot 2017-04-10 at 8 46 43 pm

Desktop:
screen shot 2017-04-10 at 8 47 14 pm

P.S. The “clear notifications” button remains in the right spot on mobile screens (it required the addition of a breakpoint-aware CSS class)
screen shot 2017-04-10 at 8 47 37 pm

To-do:

  • Fix horizontal scrolling margin
  • Make sure “clear column” button is still in the right place
    • On desktop
    • On mobile
  • Check column settings opening behaviour isn’t adversely affected

This improves horizontal scrolling behaviour significantly; scrolled flex elements are... a little weird.
@ticky ticky changed the title [WIP] Improve scrolling behaviour Improve scrolling behaviour Apr 10, 2017
@ticky
Copy link
Contributor Author

ticky commented Apr 10, 2017

Updated, having verified the behaviour in all environments I can find it affects. Now with screenshots and rationale! ✨

@Gargron Gargron merged commit db7c7d1 into mastodon:master Apr 10, 2017
@ticky ticky mentioned this pull request Apr 10, 2017
Gargron added a commit that referenced this pull request Apr 13, 2017
Fix username styling regression introduced in #1063
Fix report screen background regression introduced in #1415
Gargron added a commit that referenced this pull request Apr 13, 2017
…#1699)

Fix username styling regression introduced in #1063
Fix report screen background regression introduced in #1415
Nyoho referenced this pull request in Nyoho/mathtodon Apr 25, 2017
* Replace column margin with padding

This improves horizontal scrolling behaviour significantly; scrolled flex elements are... a little weird.

* Move clear column button styling to css
Nyoho referenced this pull request in Nyoho/mathtodon Apr 25, 2017
…mastodon#1699)

Fix username styling regression introduced in #1063
Fix report screen background regression introduced in #1415
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Right-hand margin missing
2 participants