Fix #1220, fix #1671 - Hook up comment box to the Redux comment value #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koboldunderlord
approved these changes
Apr 13, 2017
| @@ -95,6 +95,6 @@ def hashtag_html(match) | |||
| end | |||
|
|
|||
| def mention_html(match, account) | |||
| "#{match.split('@').first}<span class=\"h-card\"><a href=\"#{TagManager.instance.url_for(account)}\" class=\"u-url mention\">@#{account.username}</a></span>" | |||
| "#{match.split('@').first}<span class=\"h-card\"><a href=\"#{TagManager.instance.url_for(account)}\" class=\"u-url mention\">@<span>#{account.username}</span></a></span>" | |||
There was a problem hiding this comment.
Other than default span formatting, does adding here do anything? Maybe worth adding id=report-username or something like that
There was a problem hiding this comment.
Well, the h-card stuff has been added by microformat folks, but the span inside the a has a visual role (underline it on hover but do not underline the @ sign)
Nyoho
pushed a commit
to Nyoho/mathtodon
that referenced
this pull request
Apr 25, 2017
tribela
pushed a commit
to tribela/mastodon
that referenced
this pull request
Feb 23, 2022
…upstream Merge upstream changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix username styling regression introduced in #1063
Fix report screen background regression introduced in #1415