Fix missing source strings and inconsistent lead text style in admin UI #16052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykzts
approved these changes
Apr 17, 2021
Comment on lines
93
to
94
| fa_icon('lock', title: I18n.t('statuses.visibilities.private')) | ||
| elsif status.direct_visibility? | ||
| fa_icon('envelope', title: I18n.t('statuses.visibilities.direct')) | ||
| end |
There was a problem hiding this comment.
Ah, maybe a mistake. I thought we didn't render direct statuses in the public view. For some reason we don't have statuses.visibilities.direct in our strings.
There was a problem hiding this comment.
Ah yes, I had missed the translation was missing :/
The proper fix should probably to add that translation string and add back the icon, even if people do not commonly access DMs through this interface, it would be reassuring to them to see a clear indication that they are indeed DMs
ClearlyClaire
added a commit
to ClearlyClaire/mastodon
that referenced
this pull request
Apr 21, 2021
Fix regression from mastodon#16052
chrisguida
pushed a commit
to Start9Labs/mastodon
that referenced
this pull request
Feb 26, 2022
chrisguida
pushed a commit
to Start9Labs/mastodon
that referenced
this pull request
Feb 26, 2022
Fix regression from mastodon#16052
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.