Fix searching for additional hashtags in hashtag column #17054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking it as a draft while I investigate the cause of the regression. |
|
The regression is caused by #16171 which used to mutate the |
Gargron
approved these changes
Nov 26, 2021
jesseplusplus
pushed a commit
to jesseplusplus/decodon
that referenced
this pull request
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The search API requires a valid token with
readorread:searchscopes, but the code for hashtag searches does not pass down the authentication token to the API module.This used to work before #16171 (so it still works in every release so far) because the API module would actually copy the
Authorizationheader to thecsrfHeaderobject on previous API calls.This PR passes the state to the API module so it can use the proper token.
Note that I am not completely sure about the performance implications of passing the state this way, although I suspect they are minor as the
stateobject should be shared across the whole application anyway.