-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change routing paths to use usernames in web UI #16171
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99616d8
to
27168c3
Compare
ykzts
approved these changes
May 7, 2021
Can this wait after the upcoming release? |
27168c3
to
77946b5
Compare
77946b5
to
539d876
Compare
539d876
to
e1d1917
Compare
I wonder if there should be an alias/redirection mechanism for the old client-side routes. Probably not a big deal but restoring/going back in the history after update is going to mess things up a bit for existing users. |
ClearlyClaire
added a commit
to ClearlyClaire/mastodon
that referenced
this pull request
Sep 26, 2021
Accounts and statuses routes need more work as they use different parameters.
ClearlyClaire
added a commit
to ClearlyClaire/mastodon
that referenced
this pull request
Sep 26, 2021
PR mastodon#16171 renamed some routes but missed some occurrences. Without mastodon#16772, this leads to unreachable routes in those cases.
Gargron
pushed a commit
that referenced
this pull request
Sep 27, 2021
* Add aliases for some WebUI routes that were renamed in #16171 Accounts and statuses routes need more work as they use different parameters. * Add aliases for /statuses/* routes * Add aliases for /accounts/* WebUI routes Does not correctly set the “active” state on the navigation tabs but this is a minor issue. * Fix some routes * Fix /accounts/:id/{media,followers,following} not loading on legacy routes
Gargron
pushed a commit
that referenced
this pull request
Sep 27, 2021
ClearlyClaire
added a commit
to ClearlyClaire/mastodon
that referenced
this pull request
Sep 28, 2021
jesseplusplus
pushed a commit
to jesseplusplus/decodon
that referenced
this pull request
Feb 10, 2022
jesseplusplus
pushed a commit
to jesseplusplus/decodon
that referenced
this pull request
Feb 10, 2022
…todon#16772) * Add aliases for some WebUI routes that were renamed in mastodon#16171 Accounts and statuses routes need more work as they use different parameters. * Add aliases for /statuses/* routes * Add aliases for /accounts/* WebUI routes Does not correctly set the “active” state on the navigation tabs but this is a minor issue. * Fix some routes * Fix /accounts/:id/{media,followers,following} not loading on legacy routes
jesseplusplus
pushed a commit
to jesseplusplus/decodon
that referenced
this pull request
Feb 10, 2022
* Fix incorrect use of old WebUI paths PR mastodon#16171 renamed some routes but missed some occurrences. Without mastodon#16772, this leads to unreachable routes in those cases. * Fix floating action button being displayed on statuses and compose screen
Phroneris
added a commit
to Phroneris/StylusUserCSS-Phroneris
that referenced
this pull request
Apr 13, 2022
* 「トゥート」→「投稿」 * マストドンv3.4.0からの登録年月日表示に対応 * マストドンv3.5.0からの新形式ユーザーURLに対応 * これ→ mastodon/mastodon#16171 * プロフィールにおいて、補足・メモ・文を欠く場合の縦余白を修正 * 固定投稿の検出方法を新旧併用式に変更 * 主に数値計算におけるコード規約として、「元のデザインで用いられている値」を表す `((固定値))` を導入 * その他微調整
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #15509, the
/web
prefix is kept for now/accounts/:id
/@:username
/accounts/:id/followers
/@:username/followers
/accounts/:id/following
/@:username/following
/accounts/:id/with_replies
/@:username/with_replies
/accounts/:id/media
/@:username/media
/statuses/:id
/@:username/:id
/statuses/:id/reblogs
/@:username/:id/reblogs
/statuses/:id/favourites
/@:username/:id/favourites
/statuses/new
/publish
/timelines/home
/home
/timelines/public
/public
/timelines/public/local
/public/local
/timelines/direct
/conversations
/timelines/tag/:hashtag
/tags/:hashtag
/timelines/list/:id
/lists/:id