Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change reblogs to not count towards hashtag trends anymore #17501

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Feb 10, 2022

With #17431 there will be overlap between top trending hashtags and top trending posts. Returning to only counting by volume of original posts makes sense here.

@Gargron Gargron force-pushed the fix-do-not-count-reblogs-towards-tag-trends branch 2 times, most recently from db543f9 to 12e4fd7 Compare February 10, 2022 19:50
Copy link
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks sound, but this reverts a behavior introduced in 3.4.0. If the only rationale is that it overlaps with the top trending posts feature, I'm afraid it would only push harder for a feature that I think is damageable.

@Gargron Gargron force-pushed the fix-do-not-count-reblogs-towards-tag-trends branch from 12e4fd7 to e867c4e Compare February 11, 2022 20:07
@Gargron Gargron merged commit a27729e into main Feb 11, 2022
@Gargron Gargron deleted the fix-do-not-count-reblogs-towards-tag-trends branch February 11, 2022 20:16
@psydwannabe
Copy link

Bummer. On smaller instances, this really made trending tags feel like it was more responsive to our community, and a lot more active in general.

@Gargron
Copy link
Member Author

Gargron commented Mar 8, 2022

If a popular post used multiple hashtags, your top trending hashtags would all be there because of a single post. I think that was not very useful and a bit misleading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants