Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trends returning less results per page when filtered in REST API #17996

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Apr 8, 2022

  • Change filtering and pagination to occur in SQL instead of Redis
  • Change rank/score displayed on trends in admin UI to be locale-specific

@Gargron Gargron added the bug Something isn't working label Apr 8, 2022
@Gargron Gargron force-pushed the fix-trends-statuses-incomplete-results branch from af8c992 to 26da0dc Compare April 8, 2022 13:14
- Change filtering and pagination to occur in SQL instead of Redis
- Change rank/score displayed on trends in admin UI to be locale-specific
@Gargron Gargron force-pushed the fix-trends-statuses-incomplete-results branch from 26da0dc to 33a3f1c Compare April 8, 2022 14:12
Copy link
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This substantially increases the queries' complexity… though this probably remains largely acceptable.

@Gargron Gargron merged commit fd9a9b0 into main Apr 8, 2022
@Gargron Gargron deleted the fix-trends-statuses-incomplete-results branch April 8, 2022 15:10
kadoshita pushed a commit to kadoshita/mastodon that referenced this pull request Apr 9, 2022
…astodon#17996)

- Change filtering and pagination to occur in SQL instead of Redis
- Change rank/score displayed on trends in admin UI to be locale-specific
koba-lab added a commit to koba-lab/mastodon that referenced this pull request Apr 12, 2022
* commit 'ed5491e5de6ede501715c421ad5fa53493f61250': (45 commits)
  Bump version to 3.5.1 (mastodon#18000)
  Fix error resposes for `from` search prefix (mastodon#17963)
  Add v3.5.x to SECURITY.md (mastodon#17998)
  Fix dangling language-specific trends (mastodon#17997)
  Auto-fill timeline gaps when getting re-connecting to Websocket/EventSource stream (mastodon#17987)
  Fix extremely rare race condition when deleting a toot or account (mastodon#17994)
  Change e-mail notifications to only be sent when recipient is offline (mastodon#17984)
  Fix trends returning less results per page when filtered in REST API (mastodon#17996)
  Bump i18n-tasks from 0.9.37 to 1.0.8 (mastodon#17993)
  New Crowdin updates (mastodon#17897)
  Fix cookies secure flag being set when served over Tor (mastodon#17992)
  Bump gitlab-omniauth-openid-connect from 0.5.0 to 0.9.1 (mastodon#17779)
  Bump fabrication from 2.27.0 to 2.28.0 (mastodon#17960)
  Bump lograge from 0.11.2 to 0.12.0 (mastodon#17961)
  Fix migration error handling (mastodon#17991)
  Fix error re-running some migrations if they get interrupted at the wrong moment (mastodon#17989)
  Fix pagination header on empty trends responses in REST API (mastodon#17986)
  Fix potentially missing statuses when reconnecting to websocket (mastodon#17981)
  Fix failure when sending warning emails with custom text (mastodon#17983)
  Fix unset `SMTP_RETURN_PATH` environment variable causing e-mail not to send (mastodon#17982)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants