Change label of status visibility to "Only people I mention" in web UI #18146

Gargron · 2022-04-28T05:07:59Z

To avoid confusion with proper, end-to-end encrypted direct messaging functionality that's planned for the future

ClearlyClaire · 2022-04-28T15:20:43Z

The PR not only renames it but also removes a lot of menu items and remove the DM timeline altogether… While I understand some people have incorrect expectations because of how this is named, I think removing that much functionality isn't a good thing.

app/javascript/mastodon/features/compose/containers/warning_container.js

ClearlyClaire · 2022-04-28T19:57:24Z

app/javascript/mastodon/features/direct_timeline/index.js

@@ -10,7 +10,7 @@ import { connectDirectStream } from '../../actions/streaming';
 import ConversationsListContainer from './containers/conversations_list_container';

 const messages = defineMessages({
-  title: { id: 'column.direct', defaultMessage: 'Direct messages' },
+  title: { id: 'column.conversations', defaultMessage: 'Conversations' },


What about “personal message”? Still convey a similar idea but more reminiscent of BBS and similar communities smaller than Twitter.

PMs and DMs are often used interchangeably and I would like to avoid any confusion

Honestly I fail to see how “Personal Message” may convey an idea of encryption, like I said it's pretty much reminiscent of BBS and other small-scale forums where you have unencrypted PMs with admins you may personally know.

My problem with “Conversations” is that we already use that term for threads (e.g. “Mute conversation”, and what I wanted to do for the improved filtering system)

I give up, Conversations is fine.

app/javascript/mastodon/features/direct_timeline/index.js

app/javascript/mastodon/features/getting_started/index.js

app/javascript/mastodon/features/ui/index.js

- Change name of conversations column in web UI - Change hotkey for opening conversations column from `g d` to `g c` in web UI - Remove shortcuts for creating direct-visibility statuses from web UI

leahoswald · 2022-04-29T09:21:57Z

As and admin (for chaos.social) I want to vote against this change in the current form. The PR is missing a full description for a lot of changes, for example renaming toots to posts in a lot of places. It makes things not more clear it is more confusing and a bad decision from an UI/UX point of view. Also doing such a big change without any discussion is really bad practice.

Don't get me wrong, we could discuss all these changes but not merged in one PR that does look like something else.

koyuawsmbrtn · 2022-04-29T09:26:37Z

Renaming toot to post in a lot of places has already been done. The change was actually there to avoid confusion, because "toot" isn't a really a name outside of Mastodon. When I say "I am tooting now" nobody would know that I mean Mastodon. It makes sense.

The change from "Direct" to "Only people I mention" comes from the official Mastodon app as end-to-end encrypted messages are planned. It makes sense, because it implies what it does and doesn't confuse people who expect an actual direct message UI. I could see the "Conversations" tab getting replaced with the chat system as well.

leahoswald · 2022-04-29T09:32:52Z

Okay, maybe the "toot changes" were just bad commit practice then.

Also the change of the name could be discusses I'm just concerned abut the other changes @ClearlyClaire mentioned.

Gargron · 2022-04-29T09:33:43Z

All "toots" have already been renamed to "posts" in previous stable releases, this just cleans up some code
I would not classify it as a big change since it's just changing UI labels and removing 2 replaceable dropdown options
This is fixing a rather dire usability issue -- people treating Mastodon posts as DMs and having wrong expectations as a result

See #18079

Edit: You might be unaware that Claire's comment referred to a previous state of the PR and that the PR had been updated since.

leahoswald · 2022-04-29T09:37:12Z

This is part of the info I hoped for to find in the PR.

n0toose · 2022-04-29T16:36:30Z

As I was the person that originally opened the issue, I am just sharing a concern that the way this is now worded makes people excessively paranoid, but on the other hand, it's better than nothing at all and it's probably going to get superseded by some E2EE functionality in less than the 4 years it took for the text to get updated, without allowing any fear get displaced onto random instance owners. 😄 👍🏻

Thanks for addressing this! ⭐

…eb UI Partially reverts #18146

…eb UI (#18289) Partially reverts #18146

mastodon#18146) - Change name of conversations column in web UI - Change hotkey for opening conversations column from `g d` to `g c` in web UI - Remove shortcuts for creating direct-visibility statuses from web UI

…eb UI (mastodon#18289) Partially reverts mastodon#18146

mastodon#18146) - Change name of conversations column in web UI - Change hotkey for opening conversations column from `g d` to `g c` in web UI - Remove shortcuts for creating direct-visibility statuses from web UI

…eb UI (mastodon#18289) Partially reverts mastodon#18146

Gargron force-pushed the fix-remove-conversations-column branch from 59c5bfc to 225a4db Compare April 28, 2022 05:58

Gargron force-pushed the fix-remove-conversations-column branch from 225a4db to f5f96a9 Compare April 28, 2022 19:53

ClearlyClaire reviewed Apr 28, 2022

View reviewed changes

Gargron force-pushed the fix-remove-conversations-column branch 2 times, most recently from 743c217 to 1da7ed4 Compare April 28, 2022 21:58

Change "Direct" status visibility to "Only people I mention" in web UI

a2ccd27

- Change name of conversations column in web UI - Change hotkey for opening conversations column from `g d` to `g c` in web UI - Remove shortcuts for creating direct-visibility statuses from web UI

Gargron force-pushed the fix-remove-conversations-column branch from 1da7ed4 to a2ccd27 Compare April 28, 2022 22:19

Gargron merged commit be0bc9a into main Apr 28, 2022

Gargron deleted the fix-remove-conversations-column branch April 28, 2022 22:24

ClearlyClaire mentioned this pull request Apr 29, 2022

Change Direct Message warning to make admins' ability to access them clearer #18108

Closed

Gargron added a commit that referenced this pull request May 3, 2022

Change "Conversations" back to "Direct messages" and add warning in w…

260c4d2

…eb UI Partially reverts #18146

Gargron mentioned this pull request May 3, 2022

Change "Conversations" back to "Direct messages" and add warning in web UI #18289

Merged

Gargron added a commit that referenced this pull request May 3, 2022

Change "Conversations" back to "Direct messages" and add warning in w…

7e24487

…eb UI (#18289) Partially reverts #18146

ClearlyClaire mentioned this pull request May 3, 2022

Change “Only people I mention” to “Mentioned people only” #18291

Merged

kadoshita pushed a commit to kadoshita/mastodon that referenced this pull request May 4, 2022

Change "Conversations" back to "Direct messages" and add warning in w…

69ff268

…eb UI (mastodon#18289) Partially reverts mastodon#18146

n0toose mentioned this pull request Oct 30, 2022

Clarify that DMs can be read by instance owners #18079

Closed

n0toose mentioned this pull request Nov 21, 2022

Clarify that DMs can be read by instance operators (again) #21298

Open

ahox mentioned this pull request Nov 25, 2022

merge 3.5.3 petit-rabbits/mastodon#6

Closed

rbairwell mentioned this pull request Dec 5, 2022

DMs should be encrypted #22054

Closed

masarakki mentioned this pull request Apr 19, 2023

upgrade 3.5.8 best-friends/mastodon#1854

Closed

ClearlyClaire pushed a commit to ClearlyClaire/mastodon that referenced this pull request Jul 6, 2023

Change "Conversations" back to "Direct messages" and add warning in w…

3a79447

…eb UI (mastodon#18289) Partially reverts mastodon#18146

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change label of status visibility to "Only people I mention" in web UI #18146

Change label of status visibility to "Only people I mention" in web UI #18146

Gargron commented Apr 28, 2022

ClearlyClaire commented Apr 28, 2022

ClearlyClaire Apr 28, 2022

Gargron Apr 28, 2022

ClearlyClaire Apr 28, 2022

ClearlyClaire Apr 28, 2022

ClearlyClaire Apr 28, 2022

leahoswald commented Apr 29, 2022 •

edited

Loading

koyuawsmbrtn commented Apr 29, 2022 •

edited

Loading

leahoswald commented Apr 29, 2022

Gargron commented Apr 29, 2022 •

edited

Loading

leahoswald commented Apr 29, 2022

n0toose commented Apr 29, 2022

Change label of status visibility to "Only people I mention" in web UI #18146

Change label of status visibility to "Only people I mention" in web UI #18146

Conversation

Gargron commented Apr 28, 2022

ClearlyClaire commented Apr 28, 2022

ClearlyClaire Apr 28, 2022

Choose a reason for hiding this comment

Gargron Apr 28, 2022

Choose a reason for hiding this comment

ClearlyClaire Apr 28, 2022

Choose a reason for hiding this comment

ClearlyClaire Apr 28, 2022

Choose a reason for hiding this comment

ClearlyClaire Apr 28, 2022

Choose a reason for hiding this comment

leahoswald commented Apr 29, 2022 • edited Loading

koyuawsmbrtn commented Apr 29, 2022 • edited Loading

leahoswald commented Apr 29, 2022

Gargron commented Apr 29, 2022 • edited Loading

leahoswald commented Apr 29, 2022

n0toose commented Apr 29, 2022

leahoswald commented Apr 29, 2022 •

edited

Loading

koyuawsmbrtn commented Apr 29, 2022 •

edited

Loading

Gargron commented Apr 29, 2022 •

edited

Loading