-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change label of status visibility to "Only people I mention" in web UI #18146
Conversation
59c5bfc
to
225a4db
Compare
The PR not only renames it but also removes a lot of menu items and remove the DM timeline altogether… While I understand some people have incorrect expectations because of how this is named, I think removing that much functionality isn't a good thing. |
225a4db
to
f5f96a9
Compare
app/javascript/mastodon/features/compose/containers/warning_container.js
Show resolved
Hide resolved
@@ -10,7 +10,7 @@ import { connectDirectStream } from '../../actions/streaming'; | |||
import ConversationsListContainer from './containers/conversations_list_container'; | |||
|
|||
const messages = defineMessages({ | |||
title: { id: 'column.direct', defaultMessage: 'Direct messages' }, | |||
title: { id: 'column.conversations', defaultMessage: 'Conversations' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about “personal message”? Still convey a similar idea but more reminiscent of BBS and similar communities smaller than Twitter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PMs and DMs are often used interchangeably and I would like to avoid any confusion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly I fail to see how “Personal Message” may convey an idea of encryption, like I said it's pretty much reminiscent of BBS and other small-scale forums where you have unencrypted PMs with admins you may personally know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My problem with “Conversations” is that we already use that term for threads (e.g. “Mute conversation”, and what I wanted to do for the improved filtering system)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I give up, Conversations is fine.
743c217
to
1da7ed4
Compare
- Change name of conversations column in web UI - Change hotkey for opening conversations column from `g d` to `g c` in web UI - Remove shortcuts for creating direct-visibility statuses from web UI
1da7ed4
to
a2ccd27
Compare
As and admin (for chaos.social) I want to vote against this change in the current form. The PR is missing a full description for a lot of changes, for example renaming toots to posts in a lot of places. It makes things not more clear it is more confusing and a bad decision from an UI/UX point of view. Also doing such a big change without any discussion is really bad practice. Don't get me wrong, we could discuss all these changes but not merged in one PR that does look like something else. |
Renaming toot to post in a lot of places has already been done. The change was actually there to avoid confusion, because "toot" isn't a really a name outside of Mastodon. When I say "I am tooting now" nobody would know that I mean Mastodon. It makes sense. The change from "Direct" to "Only people I mention" comes from the official Mastodon app as end-to-end encrypted messages are planned. It makes sense, because it implies what it does and doesn't confuse people who expect an actual direct message UI. I could see the "Conversations" tab getting replaced with the chat system as well. |
Okay, maybe the "toot changes" were just bad commit practice then. Also the change of the name could be discusses I'm just concerned abut the other changes @ClearlyClaire mentioned. |
See #18079 Edit: You might be unaware that Claire's comment referred to a previous state of the PR and that the PR had been updated since. |
This is part of the info I hoped for to find in the PR. |
As I was the person that originally opened the issue, I am just sharing a concern that the way this is now worded makes people excessively paranoid, but on the other hand, it's better than nothing at all and it's probably going to get superseded by some E2EE functionality in less than the 4 years it took for the text to get updated, without allowing any fear get displaced onto random instance owners. 😄 👍🏻 Thanks for addressing this! ⭐ |
…eb UI Partially reverts #18146
mastodon#18146) - Change name of conversations column in web UI - Change hotkey for opening conversations column from `g d` to `g c` in web UI - Remove shortcuts for creating direct-visibility statuses from web UI
…eb UI (mastodon#18289) Partially reverts mastodon#18146
mastodon#18146) - Change name of conversations column in web UI - Change hotkey for opening conversations column from `g d` to `g c` in web UI - Remove shortcuts for creating direct-visibility statuses from web UI
…eb UI (mastodon#18289) Partially reverts mastodon#18146
To avoid confusion with proper, end-to-end encrypted direct messaging functionality that's planned for the future