Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add language dropdown to compose in web UI #18420

Merged
merged 1 commit into from
May 16, 2022
Merged

Add language dropdown to compose in web UI #18420

merged 1 commit into from
May 16, 2022

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented May 15, 2022 •
edited

@Gargron Gargron added ui Front-end, design NLnet Funded by NLnet, see https://nlnet.nl/project/Mastodon/ labels May 15, 2022
@Gargron Gargron force-pushed the feature-language-dropdown branch 3 times, most recently from 08b03da to b24138d Compare May 15, 2022 19:29
@Gargron Gargron force-pushed the feature-language-dropdown branch from b24138d to adda216 Compare May 15, 2022 19:36
@Gargron Gargron marked this pull request as ready for review May 15, 2022 23:03
@tribela
Copy link
Contributor

tribela commented May 16, 2022

Finally!

@Gargron Gargron merged commit 0cdb077 into main May 16, 2022
@Gargron Gargron deleted the feature-language-dropdown branch May 16, 2022 09:18
@ykzts
Copy link
Sponsor Member

ykzts commented May 16, 2022

Settings Web UI
Screenshot on Settings Screenshot on home

It seems that if "Posting language" is set to "Same as interface language", the language cannot be selected in the Web UI. I missed it.

@ykzts ykzts mentioned this pull request May 16, 2022
Merged
@Izorkin
Copy link
Contributor

Izorkin commented May 17, 2022

Is it possible to add the ability to pin multiple languages in the dropdown menu? In order not to scroll through the list of languages each time.

@Gargron
Copy link
Member Author

Gargron commented May 17, 2022

Your frequently used languages appear at the top.

@ykzts ykzts mentioned this pull request May 19, 2022
Merged
@vasilisvg
Copy link

I was wondering what the output is of this select. When I select Dutch, for instance, I would expect the lang=nl attribute to appear on the <article> tag that displays the post. This would indeed be very handy for people who use screen readers. But, as far as I can tell, this attribute doesn't appear in the HTML. Or is there another reason to use this select?

kadoshita pushed a commit to kadoshita/mastodon that referenced this pull request May 27, 2022
@Gargron @kadoshita
Add language dropdown to compose in web UI (mastodon#18420)
489cbf8
@rwmpelstilzchen rwmpelstilzchen mentioned this pull request May 27, 2022
Open
@pludi pludi mentioned this pull request Jun 20, 2022
Closed
@Arkanosis Arkanosis mentioned this pull request Nov 7, 2022
Open
@leo60228 leo60228 mentioned this pull request Nov 10, 2022
Open
@ahox ahox mentioned this pull request Nov 25, 2022
Closed
@jorgesat jorgesat mentioned this pull request Dec 5, 2022
Open
@Mart-Bogdan
Copy link

Wow. That's so great. I've started using Mastodon recently. And I thought this was old feture. But it was jsut added. And I really like this feature.

Thank you for making it possible.

@masarakki masarakki mentioned this pull request Apr 19, 2023
Closed
ClearlyClaire pushed a commit to ClearlyClaire/mastodon that referenced this pull request Jul 6, 2023
@Gargron
Add language dropdown to compose in web UI
dc2247c 
mastodon#18420

* Update yarn.lock

For https://gitlab.com/kibicat/mastodon/-/merge_requests/15

* Add missing comma

For https://gitlab.com/kibicat/mastodon/-/merge_requests/15

This was causing the list of supported languages to not be serialized to
the front end. Very sneaky mistake. ---cat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykzts ykzts ykzts approved these changes

Assignees
No one assigned
Labels
NLnet Funded by NLnet, see https://nlnet.nl/project/Mastodon/ ui Front-end, design
Projects
None yet
Milestone
No milestone
6 participants
@Gargron @tribela @ykzts @Izorkin @vasilisvg @Mart-Bogdan