Add interaction modal to logged-out web UI #19306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
force-pushed
the
feature-interaction-modal
branch
2 times, most recently
from
ec1a267
to
f1da3d0
Compare
Gargron
force-pushed
the
feature-interaction-modal
branch
from
f1da3d0
to
cea9475
Compare
ykzts
approved these changes
Oct 7, 2022
|
I like that modal. Even though the copy-and-paste thing is slightly clunky, it's not worse than what we had and it has the merit of explaining the feature. One thing that would benefit from some work though is making the “Sign in” and “Create account” actions not break the flow. As it stands, after logging in, you're not brought back to the action you were attempting, and you may not be brought back to the content itself. Not sure how to best do that, though. |
kadoshita
pushed a commit
to kadoshita/mastodon
that referenced
this pull request
Nov 19, 2022
nametoolong
pushed a commit
to nametoolong/nuage
that referenced
this pull request
Nov 20, 2022
|
Maybe this behavior is good for newcomers but I'd check if visitor have already seen this dialog plenty times and keep old "remote interact" for them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of bringing up the remote interaction dialog in a pop-up window, show a modal that explains what the action does and gives instructions how to proceed with a local or remote account.