Fix duplicate featured tags #19403
Merged
Fix duplicate featured tags #19403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix #19220 ? |
|
Oh, that's exactly what I'm talking about. Error handling on the setting page was missing. Please wait a moment. |
Gargron
approved these changes
Oct 21, 2022
Gargron
reviewed
Oct 22, 2022
app/models/featured_tag.rb
Outdated
| @@ -58,5 +60,6 @@ def validate_featured_tags_limit | |||
| def validate_tag_name | |||
| errors.add(:name, :blank) if @name.blank? | |||
| errors.add(:name, :invalid) unless @name.match?(/\A(#{Tag::HASHTAG_NAME_RE})\z/i) | |||
| errors.add(:name, I18n.t('featured_tags.errors.duplicate_hashtag')) if FeaturedTag.by_name(@name).where(account_id: account_id).exists? | |||
There was a problem hiding this comment.
Maybe this should trigger the normal :taken error message?
Gargron
approved these changes
Oct 22, 2022
kadoshita
pushed a commit
to kadoshita/mastodon
that referenced
this pull request
Nov 19, 2022
* Fix duplicate featured tags * Add unique tag name validator * Fix error message
nametoolong
pushed a commit
to nametoolong/nuage
that referenced
this pull request
Nov 20, 2022
* Fix duplicate featured tags * Add unique tag name validator * Fix error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug that allowed featured tags with the same tag to be created because the unique constraint was not set. Fix this.