Fix vacuum scheduler missing lock, locks never expiring #19458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove vacuuming of orphaned preview cards
Gargron
force-pushed
the
fix-vacuum-scheduler
branch
from
8956007
to
4cdfaf4
Compare
ykzts
approved these changes
Oct 25, 2022
ClearlyClaire
approved these changes
Oct 26, 2022
| @@ -35,4 +35,5 @@ | |||
| config.reaper_count = 1000 | |||
| config.reaper_interval = 600 | |||
| config.reaper_timeout = 150 | |||
| config.lock_ttl = 50.days.to_i | |||
There was a problem hiding this comment.
My only concern is that potentially causing issues if we ever bump the number of retries or change the retry function.
kadoshita
pushed a commit
to kadoshita/mastodon
that referenced
this pull request
Nov 19, 2022
Remove vacuuming of orphaned preview cards
nametoolong
pushed a commit
to nametoolong/nuage
that referenced
this pull request
Nov 20, 2022
Remove vacuuming of orphaned preview cards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove vacuuming of orphaned preview cards