Remove inline CSS in SVG logo #20814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These can probably be dropped altogether rather than moved, as the logos currently work fine with the CSP blocking those styles. |
|
Yes it is, you reminded me thank you🤩 |
luxiaba
changed the title
mastodon/basics.scss to ensure match with CSP policy
ClearlyClaire
approved these changes
Nov 15, 2022
ClearlyClaire
changed the title
|
The inline style is there for when/if somebody uses the logo file standalone. |
|
How about filling the color |
|
No, the path currently uses |
neatchee
pushed a commit
to neatchee/mastodon
that referenced
this pull request
Dec 16, 2022
nametoolong
pushed a commit
to nametoolong/nuage
that referenced
this pull request
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move inline css
style="color:#fff"in svg logo tomastodon/basics.scssto comply with Content Security Policy, otherwise there are some "Refused to apply" errors in production env like below: