Fix profile avatar being slightly offset into left border (fixes #20822)

[RiedleroD]

I don't know why it was shifted in the first place or why the width is specified twice, but this fixes the problem, so it looks fine to me.

edit: I now do know why it was shifted, but I ignored the width thing because it's not part of the PR and I don't have to touch the codebase again hopefully

[ClearlyClaire]

I think this was here to align the avatar with the text. Maybe moving margin-left: -2px to the container element would make sense.

[patrick91]

I've done something like this in my instance to add transparent bg, it worked well :)

[hampuskraft]

@RiedleroD Would it be possible to do as @ClearlyClaire suggested and move it to the account__header__tabs class instead of removing the negative margin? That way, the avatar is perfectly aligned with the elements below it.

[RiedleroD]

@hampuskraft certainly, but negative margin is usually bad practice. I'll see if there's a better way to do it later today and commit the best way I can find.

[hampuskraft]

In this case, I think a negative margin is the best (if not the only) solution. But if an alternative exists, that could be interesting.

[RiedleroD]

Well if I knew more about the codebase, I'd simply remove the overflow:hidden that cuts off the border, and change the border into an outline, so it doesn't affect layouting. I don't know why the overflow was hidden though, because it's apparrently impossible to comment your CSS code (glaring at whoever wrote that, not looking up who it was via git blame though)

anyway, to resolve this as quickly as possible, this workaround is good enough for now. Someone should really rewrite that mess though, before too much technical debt accumulates and mastodon ends up looking like youtube or something.

[RiedleroD]

btw, someone with a working mastodon testing setup should check if my changes actually work as intended. I double- and triple-checked with the changes I make via inspector in my browser, but mastodon is important enough for that to be insufficient. I won't be setting up a whole testing environment for a two-line change though, especially as reviews are required anyway.

[hampuskraft]

This should do the trick, but you might want to fix the formatting 😅

[RiedleroD]

"Hmm I wonder why it takes this long to get looked at by the crew"

Pull requests that do not pass automated checks may not be reviewed

I thought the mastodon team was lackin but it was I who was the fool all along :I

well, I'm just glad I finally looked at the contributing guidelines instead of blaming it on "gargron bad hurr durr"