Add ability to set minimum Puma threads with MIN_THREADS environment variable #21048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me |
ykzts
approved these changes
Nov 22, 2022
ineffyble
added
deployment
|
Moving the Helm chart out to mastodon/chart |
|
@Gargron This isn't directly related to the helm chart, but rather expands control of Puma via environment variables. So I'd still like to see it merged :) |
Gargron
requested changes
Dec 15, 2022
config/puma.rb
Outdated
| @@ -1,7 +1,8 @@ | |||
| persistent_timeout ENV.fetch('PERSISTENT_TIMEOUT') { 20 }.to_i | |||
|
|
|||
| threads_count = ENV.fetch('MAX_THREADS') { 5 }.to_i | |||
| threads threads_count, threads_count | |||
| min_threads_count = ENV.fetch('MIN_THREADS') { 5 }.to_i | |||
There was a problem hiding this comment.
This changes behaviour, perhaps fallback to MAX_THREADS value instead? Unless changing the behaviour is a performance improvement of some sort.
There was a problem hiding this comment.
You're right, good catch. Fixed it to default to max_thread_count as you suggested. This should ensure identical behavior if MIN_THREADS is not set.
jimeh
force-pushed
the
min-puma-threads
branch
from
c597cff
to
471573d
Compare
Gargron
approved these changes
Jan 6, 2023
nametoolong
pushed a commit
to nametoolong/nuage
that referenced
this pull request
Jan 12, 2023
73 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.