Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hidden label causing accessibility issue for search inputs #21275

Merged
merged 3 commits into from Dec 15, 2022
Merged

Fix hidden label causing accessibility issue for search inputs #21275

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d0c9c6
Try unhiding search label.
alexstine Nov 21, 2022
46a0e7b
Use aria-label. Remove label as empty labels are useless.
alexstine Nov 21, 2022
d4234fc
Remove addition of package-lock.json.
alexstine Nov 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/javascript/mastodon/features/compose/components/search.js
View file
Open in desktop
Expand Up @@ -124,7 +124,7 @@ class Search extends React.PureComponent {
return (
<div className='search'>
<label>
<span style={{ display: 'none' }}>{intl.formatMessage(messages.placeholder)}</span>
<span>{intl.formatMessage(signedIn ? messages.placeholderSignedIn : messages.placeholder)}</span>
<input
ref={this.setRef}
className='search__input'
Expand Down