Fix hidden label causing accessibility issue for search inputs #21275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
requested changes
Nov 21, 2022
|
@ClearlyClaire Looks better now? I hope this also does not break the visual layout but to have an empty label is really not great. Added the |
ClearlyClaire
approved these changes
Nov 21, 2022
neatchee
pushed a commit
to neatchee/mastodon
that referenced
this pull request
Dec 16, 2022
…don#21275) * Try unhiding search label. * Use aria-label. Remove label as empty labels are useless. * Remove addition of package-lock.json.
nametoolong
pushed a commit
to nametoolong/nuage
that referenced
this pull request
Jan 12, 2023
…don#21275) * Try unhiding search label. * Use aria-label. Remove label as empty labels are useless. * Remove addition of package-lock.json.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6850
There is a label wrapped around the search input that contains
style="display:none;". This is useless and should be removed since this will not be read by screen readers or shown visually at any point. Addsaria-labelas relying onplaceholderattribute is not meeting the accessibility spec.