Fix infinite loading instead of soft 404 for non-existing remote accounts #21303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaciekBaron
reviewed
Nov 21, 2022
| @@ -7,6 +8,8 @@ const initialState = ImmutableMap(); | |||
|
|
|||
| export default function accountsMap(state = initialState, action) { | |||
| switch(action.type) { | |||
| case ACCOUNT_LOOKUP_FAIL: | |||
There was a problem hiding this comment.
Should we also cater here for ACCOUNT_FETCH_FAIL?
There was a problem hiding this comment.
No, ACCOUNT_FETCH_FAIL is for getting an Account object from its id, accounts_map is for storing a mapping from acct handle to id.
ineffyble
approved these changes
Nov 22, 2022
Gargron
approved these changes
Nov 27, 2022
Closed
nametoolong
pushed a commit
to nametoolong/nuage
that referenced
this pull request
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21278, #21021