Fix media markup #21420
Merged
Fix media markup #21420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings the markup of the MediaItem component on par with the Item component from media_gallery.
Gargron
approved these changes
Dec 15, 2022
neatchee
pushed a commit
to neatchee/mastodon
that referenced
this pull request
Dec 16, 2022
This brings the markup of the MediaItem component on par with the Item component from media_gallery. Co-authored-by: Effy Elden <effy@effy.space>
nametoolong
pushed a commit
to nametoolong/nuage
that referenced
this pull request
Jan 12, 2023
This brings the markup of the MediaItem component on par with the Item component from media_gallery. Co-authored-by: Effy Elden <effy@effy.space>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There’s a difference in markup for
gifvattachments when viewing in a toot vs when viewing on a profile media page. The difference is atitleattribute that is missing on a profile media page.Example URLs:
[title].[title]set.This PR brings the markup of the MediaItem component on par with the Item component from media_gallery.