Fix GIF autoplay on iOS #21422
Merged
Fix GIF autoplay on iOS #21422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Gargron you should have the context here |
Gargron
approved these changes
Nov 27, 2022
Closed
nametoolong
pushed a commit
to nametoolong/nuage
that referenced
this pull request
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets autoplay working on my iPhone. It's pretty straightforward, and I'm not seeing any changes in behavior on desktop Chrome/Firefox: autoplay still works when enabled in settings, hovering causes it to play when autoplay is disabled, and clicking on the thumbnail still opens the full-screen media viewer and starts playing.
I see that autoplay on iOS was intentionally disabled by 47bf592, but I'm not finding an issue or PR explaining the rationale.
Fixes #6217