Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 500 error when trying to migrate to an invalid address #21462

Merged
merged 2 commits into from Dec 7, 2022
Merged

Fix 500 error when trying to migrate to an invalid address #21462

merged 2 commits into from Dec 7, 2022

Conversation

ClearlyClaire
Copy link
Contributor

No description provided.

@ClearlyClaire
Copy link
Contributor Author

It does fix at least the case of an otherwise-ok acct handle in which the domain part has an extra space (e.g. foo@bar. com).

If you have another example of input that causes a 500 error, please share it.

@ineffyble ineffyble added bug Something isn't working activitypub Protocol-related changes, federation labels Nov 24, 2022
@Gargron Gargron merged commit b59fb28 into mastodon:main Dec 7, 2022
nametoolong pushed a commit to nametoolong/nuage that referenced this pull request Jan 12, 2023
@ClearlyClaire
Fix 500 error when trying to migrate to an invalid address (mastodon#…
e80811e 
…21462)

* Fix 500 error when trying to migrate to an invalid address

* Add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykzts ykzts ykzts approved these changes

Assignees
No one assigned
Labels
activitypub Protocol-related changes, federation bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ClearlyClaire @ykzts @Gargron @ineffyble