Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in handler function call name #21829

Merged
merged 1 commit into from Dec 15, 2022
Merged

Conversation

nschonni
Copy link
Contributor

Did a pass with cSpell to see if there was much. Mostly some minor things in comments/tests, but this was a functional issue, so I kept it separate from the other changes

@nschonni nschonni closed this Dec 1, 2022
@nschonni nschonni reopened this Dec 1, 2022
@nschonni
Copy link
Contributor Author

nschonni commented Dec 1, 2022

@ClearlyClaire I noticed a few of mine got stuck on the build-and-test CI job. Is there anything I need to do, or is that something that needs to manually kicked off by a maintainer?

@ClearlyClaire
Copy link
Contributor

@ClearlyClaire I noticed a few of mine got stuck on the build-and-test CI job. Is there anything I need to do, or is that something that needs to manually kicked off by a maintainer?

I'm not sure what can be done, and I'm not seeing anything I can do from my side. But I can tell from the code change that your PR would not change any of the test results anyway.

@nschonni
Copy link
Contributor Author

nschonni commented Dec 1, 2022

Not a problem, I'll try to rebase later and see if the CI likes that 😄

@connorshea
Copy link
Contributor

@nschonni @ClearlyClaire FYI since I had this exact same problem: what's probably causing this is that you created your own CircleCI project for mastodon (e.g. nschonni/mastodon), and for whatever reason that confuses CircleCI and prevents it from running the CI job in the main mastodon/mastodon project, which is what the status checks actually want to see. So try going into Circle, deleting the mastodon project under your namespace, and then merge main into your branch to trigger a new run of CI.

@nschonni
Copy link
Contributor Author

nschonni commented Dec 3, 2022

Thanks for the suggestion. I went and checked to see if that was the case, but I ended up remembering that I had deleted my CircleCI account some time ago because I was getting spam notifications that they wouldn't block properly.

@nschonni
Copy link
Contributor Author

nschonni commented Dec 3, 2022

I definitely seems like there is some sort of account confusion though

Could not find a usable config.yml, you may have revoked the CircleCI OAuth app.
Please sign out of CircleCI and log back in with your VCS before triggering a new pipeline.

@connorshea
Copy link
Contributor

ah, yeah in that case you need a CircleCI account connected

@nschonni
Copy link
Contributor Author

nschonni commented Dec 3, 2022

Looks like configuring it and rebasing got it running

@ineffyble ineffyble added bug Something isn't working ui Front-end, design labels Dec 10, 2022
@Gargron Gargron merged commit 72a8af8 into mastodon:main Dec 15, 2022
@nschonni nschonni deleted the Layoute branch December 15, 2022 16:27
neatchee pushed a commit to neatchee/mastodon that referenced this pull request Dec 16, 2022
nametoolong pushed a commit to nametoolong/nuage that referenced this pull request Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui Front-end, design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants