Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade Node.js requirement to 14+ #22342

Merged
merged 1 commit into from Jan 5, 2023
Merged

Downgrade Node.js requirement to 14+ #22342

merged 1 commit into from Jan 5, 2023

Conversation

ClearlyClaire
Copy link
Contributor

I don't think there was anything warranting bumping the minimum required version just yet.

@nschonni

This comment was marked as outdated.

Sign in to view
ineffyble
ineffyble approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@ineffyble ineffyble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In retrospect I should have left engines as-is, I wanted to keep everything aligned, but there's a difference between "version used for X", and "semantic version range that's used to prevent usage".

@Gargron Gargron merged commit bf5fc20 into mastodon:main Jan 5, 2023
nametoolong pushed a commit to nametoolong/nuage that referenced this pull request Jan 12, 2023
@ClearlyClaire
Downgrade Node.js requirement to 14+ (mastodon#22342)
0ebd0fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykzts ykzts ykzts approved these changes

@ineffyble ineffyble ineffyble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ClearlyClaire @nschonni @ykzts @ineffyble @Gargron