Fix possible race conditions when suspending/unsuspending accounts #22363
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when suspending or unsuspending an account, the
suspended_at
flag is immediately updated, and the heavy work is performed in a background job. However, the background job sets the flag again (losing suspension origin in the process!) if it isn't set, which can lead to surprising and unwanted results: if an account is unsuspended before the suspension worker runs:Therefore, this PR changes the suspension/unsuspension worker logics to not set the suspension flag, but check it instead: the appropriate worker will only be scheduled after the flag has been set appropriately on the call site, so this should be safe.