Check OpenSearch compatibility version instead of regular version #22422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VyrCossont
force-pushed
the
opensearch-compatibility
branch
from
f551110
to
0ec691d
Compare
VyrCossont
commented
Dec 17, 2022
| @@ -13,7 +13,14 @@ def pass? | |||
|
|
|||
| def message | |||
| if running_version.present? | |||
| Admin::SystemCheck::Message.new(:elasticsearch_version_check, I18n.t('admin.system_checks.elasticsearch_version_check.version_comparison', running_version: running_version, required_version: required_version)) | |||
There was a problem hiding this comment.
This change is only to fix a linter error about line length in this file.
ClearlyClaire
approved these changes
Dec 19, 2022
|
Just wanna chime in that I've been running OpenSearch with Mastodon for a few weeks on my small instance and it seems to be just fine, aside from the warning that this fixes. |
|
This seems to actually cause spurious warnings with ElasticSearch 7.x, as ElasticSearch 7.x will accept clients using the 6.8 version of the protocol, thus messing with our comparison. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSearch clusters have a
version.numberfield in their info which reflects the actual version of OpenSearch and aversion.minimum_wire_compatibility_versionthat reflects the version of compatible Elasticsearch clients. We should be checking the latter when connecting to an OpenSearch cluster. (Regular ES clusters don't have it.) This gets rid of a spurious warning when using the currently shipping OpenSearch 2.4.0, which is compatible with the ES 7.x that Mastodon expects.Fixes #18535.