Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the contrast of the chart in “poll has ended” notifications #22575

Merged
merged 2 commits into from Jan 5, 2023
Merged

Improve the contrast of the chart in “poll has ended” notifications #22575

merged 2 commits into from Jan 5, 2023

Conversation

j-f1
Copy link
Contributor

@j-f1 j-f1 commented Dec 20, 2022

Fixes #21552, fixes #20836. I’ve bumped the opacity from 0.2 to 0.5 but I think it might be better to go higher? Not sure.

Before/After:

Dark Mode

Light Mode

antimundo
antimundo approved these changes Dec 20, 2022
View reviewed changes
Copy link

@antimundo antimundo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also noticed that the opacity was a bit too low. So I think this is good change 👍

ClearlyClaire
ClearlyClaire approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but there is still significant room for improvement for the non-leading options, especially on light theme.

@j-f1
Copy link
Contributor Author

j-f1 commented Dec 22, 2022

Improved :)

Screenshot_2022-12-22 07 45 10 Screenshot_2022-12-22 07 43 41

@j-f1
Copy link
Contributor Author

j-f1 commented Dec 22, 2022

Alternatively: rgba($ui-secondary-color, 0.3):

Screenshot_2022-12-22 07 51 44 Screenshot_2022-12-22 07 50 53

@ClearlyClaire
Copy link
Contributor

Improved :)

Screenshot_2022-12-22 07 45 10 Screenshot_2022-12-22 07 43 41

I like these better, but at this point it would probably make sense special-casing the light theme one to improve the contrast further. That can be a subsequent PR though!

@Gargron Gargron merged commit b81b646 into mastodon:main Jan 5, 2023
@j-f1 j-f1 deleted the fix-ended-poll-contrast branch January 5, 2023 12:35
nametoolong pushed a commit to nametoolong/nuage that referenced this pull request Jan 12, 2023
@j-f1
Improve the contrast of the chart in “poll has ended” notifications (m…
8973452 
…astodon#22575)

* Improve the contrast of the chart in “poll has ended” notifications

* Further increase the contrast of non-leading poll options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClearlyClaire ClearlyClaire ClearlyClaire approved these changes

@antimundo antimundo antimundo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@j-f1 @ClearlyClaire @antimundo @Gargron