Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reading:autoplay:gifs to /api/v1/preferences #22706

Merged
merged 1 commit into from Jan 5, 2023

Conversation

j-f1
Copy link
Contributor

@j-f1 j-f1 commented Dec 23, 2022

This allows apps to pick up the user’s choice on whether to auto-play GIFs or not.

@Gargron Gargron merged commit 0e7549b into mastodon:main Jan 5, 2023
@j-f1 j-f1 deleted the prefs-autoplay-gifs branch January 6, 2023 22:15
nametoolong pushed a commit to nametoolong/nuage that referenced this pull request Jan 12, 2023
@neet neet mentioned this pull request Jan 20, 2023
2 tasks
@xmflsct
Copy link

xmflsct commented Jan 23, 2023

This is great! However there is no way to update this preference (or all preferences) through the API right?

@j-f1
Copy link
Contributor Author

j-f1 commented Jan 23, 2023

Not as far as I could tell — might be nice to add though!

@xmflsct
Copy link

xmflsct commented Jan 23, 2023

Not as far as I could tell — might be nice to add though!

I was wrong - digging through Mastodon's doc is challenging. 😂

https://docs.joinmastodon.org/methods/accounts/#update_credentials In fact, some of the preferences can be updated with this call. Shall we add it in there as well?

@j-f1
Copy link
Contributor Author

j-f1 commented Jan 23, 2023

That would be nice! I’ll open a PR to cross-link those parts of the docs :)

@xmflsct
Copy link

xmflsct commented Jan 23, 2023

Awesome, thank you so much!

@Gargron would it make sense to have a dedicated /preferences update method instead of using the profile one?

@trwnh
Copy link
Member

trwnh commented Jan 27, 2023

@xmflsct @j-f1 from what i can see, this PR only lets you read the autoplay preference via the preferences API. it does not seem to touch the credentials controller at all, and update_credentials is not intended to be the way to set all preferences, either -- you can only set three specific preferences related to authoring statuses, and only for historical reasons. see #7021 (and consider it half-done), i suppose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants