Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a confirmation modal #2279

Merged
merged 2 commits into from Apr 23, 2017
Merged

Add a confirmation modal #2279

merged 2 commits into from Apr 23, 2017

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Apr 21, 2017

image
image

Confirmation on:

  • Deleting toots
  • Blocking/muting
  • Clearing notifications column

- Deleting a toot
- Muting, blocking someone
- Clearing notifications

Remove source map generation from development environment, as it is a huge
performance sink hole with little gains
@Gargron Gargron changed the title [WIP] Add a confirmation modal Add a confirmation modal Apr 22, 2017
@Gargron Gargron requested a review from blackle April 22, 2017 15:24
@saper
Copy link
Contributor

saper commented Apr 22, 2017

Since blocking is reversible, maybe just a non-modal reminder that blocks can be removed from the preferences? I hate modals

@Gargron Gargron merged commit 59b1de0 into master Apr 23, 2017
@Gargron Gargron deleted the feature-confirmation-modal branch April 23, 2017 02:39
Gargron pushed a commit that referenced this pull request Apr 26, 2017
seefood pushed a commit to Toootim/mastodon that referenced this pull request Apr 28, 2017
- Deleting a toot
- Muting, blocking someone
- Clearing notifications

Remove source map generation from development environment, as it is a huge
performance sink hole with little gains
seefood pushed a commit to Toootim/mastodon that referenced this pull request Apr 28, 2017
nanos pushed a commit to nanos/mastodon that referenced this pull request Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants