-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the getting started ui more intuitive #1309
Make the getting started ui more intuitive #1309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rebase this, and add a screenshot of the chagnes?
9150435
to
363ae96
Compare
363ae96
to
e4721ca
Compare
}; | ||
|
||
ColumnSubheading.propTypes = { | ||
text: React.PropTypes.string.isRequired, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
React.PropTypes
is deprecated. Using PropTypes
(and import PropTypes from 'prop-types';)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. 😄
e4721ca
to
55a4ccc
Compare
Context
Getting started
tab change the context of the third column, while others leave the page entirely.Preferences
link navigates away from the page, while several of the links below it navigate within the column.Changes
Getting started
tab, grouping links which only change the context of the column together, and separating them visually from links which leave the page.