Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the getting started ui more intuitive #1309

Merged

Conversation

ameliavoncat
Copy link
Contributor

@ameliavoncat ameliavoncat commented Apr 9, 2017

Context

  • Some of the links in the Getting started tab change the context of the third column, while others leave the page entirely.
  • The ordering of the links makes the tab even less intuitive for a new user - the Preferences link navigates away from the page, while several of the links below it navigate within the column.

Changes

  • Re-orders the links in the Getting started tab, grouping links which only change the context of the column together, and separating them visually from links which leave the page.
  • Adds subheadings to clarify the distinction between the two groups of links.

@ineffyble ineffyble added the ui Front-end, design label Apr 9, 2017
@ashfurrow ashfurrow requested a review from Gargron April 21, 2017 17:02
Copy link
Contributor

@mjankowski mjankowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase this, and add a screenshot of the chagnes?

@ameliavoncat ameliavoncat force-pushed the more-intuitive-getting-started branch from 9150435 to 363ae96 Compare April 24, 2017 05:45
@ameliavoncat
Copy link
Contributor Author

Done. 👍

@ameliavoncat ameliavoncat force-pushed the more-intuitive-getting-started branch from 363ae96 to e4721ca Compare April 24, 2017 05:58
};

ColumnSubheading.propTypes = {
text: React.PropTypes.string.isRequired,
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React.PropTypes is deprecated. Using PropTypes (and import PropTypes from 'prop-types';).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. 😄

@ameliavoncat ameliavoncat force-pushed the more-intuitive-getting-started branch from e4721ca to 55a4ccc Compare April 25, 2017 19:12
@Gargron Gargron merged commit fbc5099 into mastodon:master Apr 25, 2017
seefood pushed a commit to Toootim/mastodon that referenced this pull request Apr 26, 2017
Gargron pushed a commit that referenced this pull request Apr 26, 2017
seefood pushed a commit to Toootim/mastodon that referenced this pull request Apr 28, 2017
seefood pushed a commit to Toootim/mastodon that referenced this pull request Apr 28, 2017
abcang added a commit to pixiv/mastodon that referenced this pull request Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Front-end, design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants