Fix ・ detection in hashtag regex to construct hashtag correctly #22888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthoghosh24
commented
Jan 1, 2023
| @@ -26,7 +26,7 @@ class Tag < ApplicationRecord | |||
| has_many :featured_tags, dependent: :destroy, inverse_of: :tag | |||
| has_many :followers, through: :passive_relationships, source: :account | |||
|
|
|||
| HASHTAG_SEPARATORS = "_\u00B7\u200c" | |||
| HASHTAG_SEPARATORS = "_\u00B7\u30FB\u200c" | |||
There was a problem hiding this comment.
Added the unicode for the character in separators to fix the issue.
ykzts
approved these changes
Jan 1, 2023
parthoghosh24
force-pushed
the
fix_hashtag_containing_period_detection
branch
from
d502d4f
to
142186f
Compare
nametoolong
pushed a commit
to nametoolong/nuage
that referenced
this pull request
Jan 12, 2023
…odon#22888) * Fix ・ detection in hashtag regex to construct hashtag correctly * Fixed rubocop liniting issues * More rubocop linting fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #22871 as per which hastag was not getting properly generated for strings containing ・