Fix account search not returning followed accounts first

[dariusk]

This makes it so that (when elasticsearch is disabled) when a user types @foo in the compose box, they are first going to get accounts they follow ordered by the usual ranking algorithm, and then second they will get accounts they do not follow, also ordered by the ranking algorithm.

This makes behavior more consistent with user expectation and also with results when elasticsearch is enabled.

[a-dows]

Please! Users are extremely unlikely to compose a new post to a random person with lots of followers rather than someone they follow.

[dariusk]

Also, I am not sure why there are linter errors happening here. They apply to lines of code I did not touch and that are the same as what I see in the currently-passing main branch.

[Gargron]

What about the join two lines up?

[dariusk]

@Gargron What about it?

[lucasgonze]

This is a good idea as a feature, and the code seems credible.

I wonder about the efficiency of the subselect. A subselect is not optimizable. Given a relatively trivial look at the query, I can imagine an approach that modifies the LEFT OUTER JOIN follows. (This is a naive perspective - I am not a Mastodon contributor).

[a-dows]

This is a good idea as a feature, and the code seems credible.

to be clear, before mastodon 4.0, followed accounts were returned first. The change to algorithm-only for search-disabled instances is new in 4.

[dariusk]

I updated the SQL and it is much improved. No nasty extra JOIN. Thanks @Gargron for the pointer

[Gargron]

For the record this is a regression in 4.0. The described behaviour has already existed in Mastodon.