-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launch onboarding tutorial on-demand #2441
Conversation
I like it! You'll have to fix the merge conflict tho. |
…aunch-onboarding-tutorial
I've merged the changes from #1309 but there is a problem: with the new headings and the added link the bottom furry elephant friend is now scrolling: I was already a bit worried about the placement here before the merged changes, now I'm really concerned. Maybe it's not a big deal, but I imagine many users have 13" screens like I do, and now have a scrollable bottom region. I'm okay with that but wanted to flag it as a possible blocker. Let me know 👍 |
…aunch-onboarding-tutorial
I'm getting many failed tests, like |
…aunch-onboarding-tutorial
🍏 Is this something we want to review as-is or should we consider moving the link somewhere else? |
With the many changes from the webpack branch, you'll have to edit this line from index.js :
|
Yeah yeah, I'm just going to close since this is a relatively easy PR once we have the design figured out in #2019. |
It's too bad, I liked this feature. 😞 |
It might still happen just not with this specific code |
I know, and I still use this code for my own instance. I look forward to have this feature officially implemented. |
This has been an oft-requested feature from users on my instance, and we've had a few open issues. I didn't get any feedback on where the button should be but users have suggested in the righthand nav column links, so that's where I put it.
Important: I also believe this fixes a bug preventing the onboarding from working, so if we don't want to merge this as-is I can create a PR just for that fix.
Fixes #2019