Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch onboarding tutorial on-demand #2441

Closed

Conversation

ashfurrow
Copy link
Contributor

This has been an oft-requested feature from users on my instance, and we've had a few open issues. I didn't get any feedback on where the button should be but users have suggested in the righthand nav column links, so that's where I put it.

Important: I also believe this fixes a bug preventing the onboarding from working, so if we don't want to merge this as-is I can create a PR just for that fix.

screen shot 2017-04-25 at 4 14 05 pm

Fixes #2019

@expenses
Copy link

expenses commented Apr 26, 2017

I like it! You'll have to fix the merge conflict tho.

@ashfurrow
Copy link
Contributor Author

I've merged the changes from #1309 but there is a problem: with the new headings and the added link the bottom furry elephant friend is now scrolling:

screen shot 2017-04-26 at 9 27 09 am

I was already a bit worried about the placement here before the merged changes, now I'm really concerned. Maybe it's not a big deal, but I imagine many users have 13" screens like I do, and now have a scrollable bottom region. I'm okay with that but wanted to flag it as a possible blocker. Let me know 👍

@ashfurrow
Copy link
Contributor Author

I'm getting many failed tests, like undefined method deep_symbolize_keys' for "Òc":String`. Any ideas? I'll try to take a closer look tomorrow.

@ashfurrow
Copy link
Contributor Author

🍏

Is this something we want to review as-is or should we consider moving the link somewhere else?

@yiskah
Copy link
Contributor

yiskah commented May 1, 2017

We need to stop putting things in that menu. I don't know how large your screen is but on my 1080p screen the menu looks like this
long menu and on my locked alt account i also have the follow requests button so it looks like this:
locked long menu
My work computer is smaller and you can't even read the one sentence of text under the menu let alone see the elephant.

Is there a better place we can put the button? I don't think it needs to be ever-present. Somewhere easy to find but easily forgotten when you don't need it anymore

@Wonderfall
Copy link
Contributor

Wonderfall commented May 2, 2017

With the many changes from the webpack branch, you'll have to edit this line from index.js :

  render() {
    const { intl, me, dispatch } = this.props;

@ashfurrow
Copy link
Contributor Author

Yeah yeah, I'm just going to close since this is a relatively easy PR once we have the design figured out in #2019.

@ashfurrow ashfurrow closed this May 8, 2017
@ashfurrow ashfurrow deleted the launch-onboarding-tutorial branch May 8, 2017 15:20
@Wonderfall
Copy link
Contributor

It's too bad, I liked this feature. 😞

@yiskah
Copy link
Contributor

yiskah commented May 8, 2017

It might still happen just not with this specific code

@Wonderfall
Copy link
Contributor

Wonderfall commented May 8, 2017

I know, and I still use this code for my own instance. I look forward to have this feature officially implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is no way to access Getting Started tips after they close
4 participants