Add media dimensions #2448
Merged
Add media dimensions #2448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add migration AddMediaAttachmentMeta, which add meta field to media_attachments - before saving attachment, set file meta if needed - add meta in api
Gargron
approved these changes
Apr 25, 2017
Gargron
requested changes
Apr 25, 2017
spec/models/media_attachment_spec.rb
Outdated
| @@ -23,5 +23,11 @@ | |||
| it 'leaves original file as-is' do | |||
| expect(media.file_content_type).to eq 'image/gif' | |||
| end | |||
|
|
|||
| it 'sets dimensions' do | |||
| expect(media.meta[:width]).to eq 600 | |||
There was a problem hiding this comment.
I think this needs to be media.file.meta
There was a problem hiding this comment.
Fixed, sorry have not setup the test env, not got it sorted.
Gargron
approved these changes
Apr 26, 2017
seefood
pushed a commit
to Toootim/mastodon
that referenced
this pull request
Apr 26, 2017
* Fixes mastodon#1985 - add migration AddMediaAttachmentMeta, which add meta field to media_attachments - before saving attachment, set file meta if needed - add meta in api * add spec * align the “size” format for image and video * fix code climate * fixes media_attachment_spec.rb
seefood
pushed a commit
to Toootim/mastodon
that referenced
this pull request
Apr 28, 2017
* Fixes mastodon#1985 - add migration AddMediaAttachmentMeta, which add meta field to media_attachments - before saving attachment, set file meta if needed - add meta in api * add spec * align the “size” format for image and video * fix code climate * fixes media_attachment_spec.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1985