Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add media dimensions #2448

Merged
merged 5 commits into from
Apr 26, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions app/models/media_attachment.rb
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ def to_param

before_create :set_shortcode
before_post_process :set_type_and_extension
before_save :set_meta

class << self
private
Expand Down Expand Up @@ -112,6 +113,30 @@ def set_type_and_extension
file.instance_write :file_name, [basename, extension].delete_if(&:empty?).join('.')
end

def set_meta
meta = populate_meta
return if meta == {}
file.instance_write :meta, meta
end

def populate_meta
meta = {}
file.queued_for_write.each do |style, file|
begin
geo = Paperclip::Geometry.from_file file
meta[style] = {
width: geo.width.to_i,
height: geo.height.to_i,
size: "#{geo.width.to_i}x#{geo.height.to_i}",
aspect: geo.width.to_f / geo.height.to_f,
}
rescue Paperclip::Errors::NotIdentifiedByImageMagickError
meta[style] = {}
end
end
meta
end

def appropriate_extension
mime_type = MIME::Types[file.content_type]

Expand Down
1 change: 1 addition & 0 deletions app/views/api/v1/statuses/_media.rabl
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ attributes :id, :remote_url, :type
node(:url) { |media| full_asset_url(media.file.url(:original)) }
node(:preview_url) { |media| full_asset_url(media.file.url(:small)) }
node(:text_url) { |media| media.local? ? medium_url(media) : nil }
node(:meta) { |media| media.file.meta }
5 changes: 5 additions & 0 deletions db/migrate/20170425131920_add_media_attachment_meta.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
class AddMediaAttachmentMeta < ActiveRecord::Migration[5.0]
def change
add_column :media_attachments, :file_meta, :json
end
end
5 changes: 3 additions & 2 deletions db/schema.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#
# It's strongly recommended that you check this file into your version control system.

ActiveRecord::Schema.define(version: 20170424112722) do
ActiveRecord::Schema.define(version: 20170425131920) do

# These are extensions that must be enabled in order to support this database
enable_extension "plpgsql"
Expand Down Expand Up @@ -120,6 +120,7 @@
t.datetime "updated_at", null: false
t.string "shortcode"
t.integer "type", default: 0, null: false
t.json "file_meta"
t.index ["shortcode"], name: "index_media_attachments_on_shortcode", unique: true, using: :btree
t.index ["status_id"], name: "index_media_attachments_on_status_id", using: :btree
end
Expand Down Expand Up @@ -332,4 +333,4 @@
end

add_foreign_key "statuses", "statuses", column: "reblog_of_id", on_delete: :cascade
end
end
26 changes: 26 additions & 0 deletions spec/models/media_attachment_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,13 @@
it 'converts original file to mp4' do
expect(media.file_content_type).to eq 'video/mp4'
end

it 'sets meta' do
expect(media.file.meta["original"]["width"]).to eq 128
expect(media.file.meta["original"]["height"]).to eq 128
expect(media.file.meta["original"]["aspect"]).to eq 1.0
end

end

describe 'non-animated gif non-conversion' do
Expand All @@ -23,5 +30,24 @@
it 'leaves original file as-is' do
expect(media.file_content_type).to eq 'image/gif'
end

it 'sets meta' do
expect(media.file.meta["original"]["width"]).to eq 600
expect(media.file.meta["original"]["height"]).to eq 400
expect(media.file.meta["original"]["aspect"]).to eq 1.5
end
end

describe 'jpeg' do
let(:media) { MediaAttachment.create(account: Fabricate(:account), file: attachment_fixture('attachment.jpg')) }

it 'sets meta for different style' do
expect(media.file.meta["original"]["width"]).to eq 600
expect(media.file.meta["original"]["height"]).to eq 400
expect(media.file.meta["original"]["aspect"]).to eq 1.5
expect(media.file.meta["small"]["width"]).to eq 400
expect(media.file.meta["small"]["height"]).to eq 267
expect(media.file.meta["small"]["aspect"]).to eq 400.0/267
end
end
end